Issue 8561032: Add DEPS grit include for bubble_border.cc.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8561032: Add DEPS grit include for bubble_border.cc. (Closed)

Created:
9 years, 1 month ago by Scott Hess - ex-Googler

Modified:
9 years, 1 month ago

Reviewers:
tfarina

CC:
chromium-reviews

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

Add DEPS grit include for bubble_border.cc. http://crrev.com/110761 fails check_deps on OSX 10.6 ERROR in /b/build/slave/Mac_10_6_Tests__dbg__2_/build/src/ui/views/bubble/bubble_border.cc Illegal include: "grit/ui_resources_standard.h" Because of no rule applying TBR=tfarina@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110784

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	ui/DEPS	View		1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

Scott Hess - ex-Googler

I do not understand why other systems are not failing this, as it seems like ...

9 years, 1 month ago (2011-11-18 23:21:00 UTC) #1

tfarina

9 years, 1 month ago (2011-11-18 23:23:16 UTC) #2

On 2011/11/18 23:21:00, shess wrote:
> I do not understand why other systems are not failing this, as it seems like
it
> should fail.

lgtm, thanks!