Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5391)

Unified Diff: chrome/test/base/scoped_command_line_override.h

Issue 8561031: Replace ScopedCommandLineOverride with TestSuite listener. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/base/scoped_command_line_override.h
diff --git a/chrome/test/base/scoped_command_line_override.h b/chrome/test/base/scoped_command_line_override.h
index 33ebd8a1ff356616230089938aa20a4fbc252d3c..f5c112b0c76b03463c35e528f32414823d3709dc 100644
--- a/chrome/test/base/scoped_command_line_override.h
+++ b/chrome/test/base/scoped_command_line_override.h
@@ -24,6 +24,17 @@
class ScopedCommandLineOverride {
public:
explicit ScopedCommandLineOverride(const std::string& new_switch);
+ explicit ScopedCommandLineOverride(CommandLine& old_command_line);
asargent_no_longer_on_chrome 2011/11/21 17:14:23 nit: const CommandLine&
+
+ // These constructors feel dopey, but they're better than the trouble of
+ // constructing a vector, and va_list won't work with references.
asargent_no_longer_on_chrome 2011/11/21 17:14:23 It might be better to group the 3 constructors tha
+ //
+ // TODO(you): if you're a C wizard, make this prettier.
+ ScopedCommandLineOverride(const std::string& switch1,
+ const std::string& switch2);
+ ScopedCommandLineOverride(const std::string& switch1,
+ const std::string& switch2,
+ const std::string& switch3);
virtual ~ScopedCommandLineOverride();
private:
CommandLine old_command_line_;
« no previous file with comments | « chrome/browser/sync/profile_sync_service_bookmark_unittest.cc ('k') | chrome/test/base/scoped_command_line_override.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698