Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 8561025: Fixes bug where ActiveInputMethodsChanged was being invoked with the (Closed)

Created:
9 years, 1 month ago by sky
Modified:
9 years, 1 month ago
Reviewers:
Yusuke Sato
CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Fixes bug where ActiveInputMethodsChanged was being invoked with the wrong InputMethodDescriptor. In this test case we end up in MaybeChangeCurrentKeyboardLayout with value.string_list_value.size() == 5 so that we don't reset current_input_method_ and instead pass in current_input_method_, which is empty. Another possible fix is to change the if to be !value.string_list_value.empty(). Not sure if that's the right fix though. BUG=104674 TEST=none R=yusukes@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110850

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/chromeos/input_method/input_method_manager.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
sky
9 years, 1 month ago (2011-11-18 21:03:58 UTC) #1
Yusuke Sato
LGTM, thanks.
9 years, 1 month ago (2011-11-19 00:29:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/8561025/1
9 years, 1 month ago (2011-11-19 00:37:50 UTC) #3
commit-bot: I haz the power
Try job failure for 8561025-1 (retry) on win_rel for step "compile" (clobber build). It's a ...
9 years, 1 month ago (2011-11-19 00:59:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/8561025/1
9 years, 1 month ago (2011-11-19 23:03:33 UTC) #5
commit-bot: I haz the power
9 years, 1 month ago (2011-11-20 00:05:32 UTC) #6
Change committed as 110850

Powered by Google App Engine
This is Rietveld 408576698