Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 8561024: Add a "Learn More" link to the Spelling bubble. (Closed)

Created:
9 years, 1 month ago by Hironori Bono
Modified:
9 years, 1 month ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, Avi (use Gerrit), ajwong+watch_chromium.org, creis+watch_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Add a "Learn More" link to the Spelling bubble. This change adds a "Learn More" link to the Spelling bubble so we can open the "Exploring Chrome's privacy features" page as our "Under the Hood" page does. BUG=103840 TEST=right click on a misspelled word. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110906

Patch Set 1 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -0 lines) Patch
M chrome/app/generated_resources.grd View 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/tab_contents/spelling_bubble_model.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/tab_contents/spelling_bubble_model.cc View 2 chunks +15 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Hironori Bono
9 years, 1 month ago (2011-11-19 00:15:53 UTC) #1
Avi (use Gerrit)
lgtm
9 years, 1 month ago (2011-11-19 00:22:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hbono@chromium.org/8561024/3001
9 years, 1 month ago (2011-11-21 10:41:16 UTC) #3
commit-bot: I haz the power
9 years, 1 month ago (2011-11-21 13:12:15 UTC) #4
Change committed as 110906

Powered by Google App Engine
This is Rietveld 408576698