Issue 8561021: Support setting fake gamepad data from WebKit

Issue 8561021: Support setting fake gamepad data from WebKit (Closed)

Created:
9 years, 1 month ago by scottmg

Modified:
9 years, 1 month ago

Reviewers:
tony

CC:
chromium-reviews, darin-cc_chromium.org

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Support setting fake gamepad data from WebKit. In support of DRT code to be added to WebKit here https://bugs.webkit.org/show_bug.cgi?id=69451 BUG=79050 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110974

Patch Set 2 : fixes per review #

Patch Set 3 : include what you use #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -0 lines)			Patch
M	webkit/support/test_webkit_platform_support.h	View	1 2	3 chunks	+5 lines, -0 lines	0 comments	Download
M	webkit/support/test_webkit_platform_support.cc	View		3 chunks	+11 lines, -0 lines	0 comments	Download
M	webkit/support/webkit_support.h	View		2 chunks	+5 lines, -0 lines	0 comments	Download
M	webkit/support/webkit_support.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

tony

http://codereview.chromium.org/8561021/diff/1/webkit/support/test_webkit_platform_support.h File webkit/support/test_webkit_platform_support.h (right): http://codereview.chromium.org/8561021/diff/1/webkit/support/test_webkit_platform_support.h#newcode107 webkit/support/test_webkit_platform_support.h:107: void setGamepadData(const WebKit::WebGamepads&); Nit: Chrome style is to name ...

9 years, 1 month ago (2011-11-18 20:12:37 UTC) #2

scottmg

9 years, 1 month ago (2011-11-18 21:20:56 UTC) #3

scottmg

> Fwd decl OK instead in this case? Duh, of course not. One sec.

9 years, 1 month ago (2011-11-18 21:21:28 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/8561021/8001

9 years, 1 month ago (2011-11-18 21:53:48 UTC) #6

commit-bot: I haz the power

Try job failure for 8561021-8001 (retry) on linux_rel for step "ui_tests". It's a second try, ...

9 years, 1 month ago (2011-11-18 23:05:26 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/8561021/8001

9 years, 1 month ago (2011-11-21 17:47:42 UTC) #8

Change committed as 110974

Expand Messages | Collapse Messages