Issue 8561019: Clear VideoRendererBase::current_frame_ when stopped.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8561019: Clear VideoRendererBase::current_frame_ when stopped. (Closed)

Created:
9 years, 1 month ago by scherkus (not reviewing)

Modified:
9 years, 1 month ago

Reviewers:
acolwell GONE FROM CHROMIUM

CC:
chromium-reviews, hclam+watch_chromium.org, ddorwin+watch_chromium.org, fischman+watch_chromium.org, acolwell+watch_chromium.org, annacc+watch_chromium.org, Paweł Hajdan Jr., vrk (LEFT CHROMIUM), scherkus (not reviewing), ihf+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Clear VideoRendererBase::current_frame_ when stopped. I previously assumed that PipelineImpl would go through a clean Pause/Flush/Stop on an error but it turns out that Stop() can be called at anytime. Fortunately a DCHECK() would catch this condition and was easily triggerable using the test case attached in bug 100434. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110778

Patch Set 1 #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -0 lines)			Patch
	M	media/filters/video_renderer_base.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	media/filters/video_renderer_base_unittest.cc	View		1 chunk	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scherkus@chromium.org/8561019/1

9 years, 1 month ago (2011-11-18 18:57:01 UTC) #3

commit-bot: I haz the power

9 years, 1 month ago (2011-11-18 20:09:40 UTC) #4

Try job failure for 8561019-1 (retry) on linux_rel for step "ui_tests".
It's a second try, previously, step "ui_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

Expand Messages | Collapse Messages