Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 8561018: wayland: use message_pump_observer common code (Closed)

Created:
9 years, 1 month ago by Mandeep Singh Baines
Modified:
9 years, 1 month ago
CC:
chromium-reviews, sadrul, brettw-cc_chromium.org, Emmanuel Saint-loubert-BiƩ, recbradford, Elliot Glaysher
Visibility:
Public.

Description

wayland: use message_pump_observer common code BUG=102903 TEST=compile Change-Id: I96c63b55a6be4623f8edd202a1642ae6f7a6eb7a R=mark@chromium.org,oshima@chromium.org,dnicoara@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110771

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix per reviewer feedback. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -23 lines) Patch
M base/message_pump_wayland.h View 2 chunks +1 line, -18 lines 0 comments Download
M base/message_pump_wayland.cc View 1 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Mandeep Singh Baines
9 years, 1 month ago (2011-11-18 18:20:16 UTC) #1
Mark Mentovai
LGTM
9 years, 1 month ago (2011-11-18 19:04:29 UTC) #2
oshima
http://codereview.chromium.org/8561018/diff/1/base/message_pump_wayland.cc File base/message_pump_wayland.cc (right): http://codereview.chromium.org/8561018/diff/1/base/message_pump_wayland.cc#newcode27 base/message_pump_wayland.cc:27: } MessagePumpObserver::WillProcessEvent is pure virtual so you don't need ...
9 years, 1 month ago (2011-11-18 19:21:27 UTC) #3
Mandeep Singh Baines
Fixed. PTAL. http://codereview.chromium.org/8561018/diff/1/base/message_pump_wayland.cc File base/message_pump_wayland.cc (right): http://codereview.chromium.org/8561018/diff/1/base/message_pump_wayland.cc#newcode27 base/message_pump_wayland.cc:27: } On 2011/11/18 19:21:28, oshima wrote: > ...
9 years, 1 month ago (2011-11-18 20:05:22 UTC) #4
oshima
LGTM
9 years, 1 month ago (2011-11-18 20:24:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msb@chromium.org/8561018/1003
9 years, 1 month ago (2011-11-18 20:28:23 UTC) #6
Mark Mentovai
LGTM (Test)
9 years, 1 month ago (2011-11-18 21:35:59 UTC) #7
commit-bot: I haz the power
9 years, 1 month ago (2011-11-18 22:39:30 UTC) #8
Change committed as 110771

Powered by Google App Engine
This is Rietveld 408576698