Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 8561016: Adds a bounds parameter to ui::Compositor::ReadPixels (Closed)

Created:
9 years, 1 month ago by pkotwicz
Modified:
9 years, 1 month ago
CC:
chromium-reviews, Ian Vollick, piman+watch_chromium.org, Paweł Hajdan Jr., jonathan.backer
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Nicer diff #

Patch Set 3 : Nicer diff #

Patch Set 4 : Nicer revision #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -20 lines) Patch
M ui/gfx/compositor/compositor.h View 1 chunk +3 lines, -2 lines 0 comments Download
M ui/gfx/compositor/compositor_cc.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/compositor/compositor_cc.cc View 1 chunk +11 lines, -4 lines 0 comments Download
M ui/gfx/compositor/compositor_gl.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/compositor/compositor_gl.cc View 2 chunks +11 lines, -8 lines 1 comment Download
M ui/gfx/compositor/layer_unittest.cc View 1 chunk +10 lines, -2 lines 0 comments Download
M ui/gfx/compositor/test_compositor.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/compositor/test_compositor.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
pkotwicz
9 years, 1 month ago (2011-11-18 17:39:59 UTC) #1
Ian Vollick
LGTM with nit http://codereview.chromium.org/8561016/diff/4010/ui/gfx/compositor/compositor_gl.cc File ui/gfx/compositor/compositor_gl.cc (right): http://codereview.chromium.org/8561016/diff/4010/ui/gfx/compositor/compositor_gl.cc#newcode582 ui/gfx/compositor/compositor_gl.cc:582: size().height() - bounds.y() - bounds.height(), I ...
9 years, 1 month ago (2011-11-18 18:13:45 UTC) #2
jonathan.backer
9 years, 1 month ago (2011-11-18 21:16:37 UTC) #3
LGTM

be sure to merge with the additional tests that vollick landed.

Powered by Google App Engine
This is Rietveld 408576698