Issue 8561014: Fixes some asserts in compositor_unittests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8561014: Fixes some asserts in compositor_unittests (Closed)

Created:
9 years, 1 month ago by Ian Vollick

Modified:
9 years, 1 month ago

Reviewers:
piman

CC:
chromium-reviews, Ian Vollick, piman+watch_chromium.org, Paweł Hajdan Jr., jonathan.backer

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Avoids some asserts with ToT WebKit by using valid layers. Using all empty layers or resetting the root layer unnecessarily was causing problems. BUG=None TEST=compositor_unittest Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110935

Patch Set 1 #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -14 lines)			Patch
	M	ui/gfx/compositor/compositor.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	ui/gfx/compositor/layer_unittest.cc	View		1 chunk	+16 lines, -14 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages