Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 8561011: Avoid explicitly using built-in new operator where possible to appease VS compiler. (Closed)

Created:
9 years, 1 month ago by Yang
Modified:
9 years, 1 month ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Avoid explicitly using built-in new operator where possible to appease Windows build. Committed: http://code.google.com/p/v8/source/detail?r=10028

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M src/elements.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/extensions/gc-extension.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/hashmap.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/scopes.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Yang
Please take a look. Weird Visual Studio behavior. Some cctests crash when using '::new' instead ...
9 years, 1 month ago (2011-11-18 11:03:08 UTC) #1
Michael Starzinger
9 years, 1 month ago (2011-11-18 11:08:13 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698