Issue 8561004: chromeos: Fix test failures in LoginUtils*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8561004: chromeos: Fix test failures in LoginUtils* (Closed)

Created:
9 years, 1 month ago by satorux1

Modified:
9 years, 1 month ago

Reviewers:
stevenjb

CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

chromeos: Fix test failures in LoginUtils* IsRunningOnChromeOS() turned out to be unnecessary. CrosLibrary::EnsureLoaded() was returning true before crrev.com/110516, as ScopedStubCrosEnabler was used in LoginUtilsTestBase. BUG=chromium-os:23154 TEST=run linux_chromeos try bot Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110656

Patch Set 1 #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -48 lines)			Patch
	M	chrome/browser/chromeos/login/login_utils.cc	View		5 chunks	+39 lines, -48 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/satorux@chromium.org/8561004/1

9 years, 1 month ago (2011-11-18 03:20:44 UTC) #3

Change committed as 110656

Expand Messages | Collapse Messages