Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 8561003: Revert 110602 - Revert 110587 - Microphone support for Pepper Flash. (Closed)

Created:
9 years, 1 month ago by viettrungluu
Modified:
9 years, 1 month ago
Reviewers:
awong
CC:
chromium-reviews, jam, yzshen+watch_chromium.org, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, ihf+watch_chromium.org
Visibility:
Public.

Description

Revert 110602 - Revert 110587 - Microphone support for Pepper Flash. [I think the Windows shared builders just need to be clobbered.] [Committing for pbrophy@adobe.com. Original review: http://codereview.chromium.org/8138008/ .] This change supports audio capture from the microphone and supplies the data through a Pepper interface. Its enumeration is limited to the default audio device that uses mono 44.1kHz. TBR=tony@chromium.org Review URL: http://codereview.chromium.org/8574029 TBR=viettrungluu@chromium.org Review URL: http://codereview.chromium.org/8569003 TBR=ajwong@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110609

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+348 lines, -90 lines) Patch
M content/renderer/pepper_plugin_delegate_impl.h View 1 chunk +5 lines, -1 line 0 comments Download
M content/renderer/pepper_plugin_delegate_impl.cc View 8 chunks +192 lines, -9 lines 0 comments Download
A + ppapi/api/dev/ppb_audio_input_dev.idl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ppapi/api/trusted/ppb_audio_input_trusted_dev.idl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ppapi/c/dev/ppb_audio_input_dev.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ppapi/c/trusted/ppb_audio_input_trusted_dev.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ppapi/cpp/dev/audio_input_dev.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ppapi/cpp/dev/audio_input_dev.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
MM ppapi/ppapi_cpp.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
MM ppapi/ppapi_proxy.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
MM ppapi/ppapi_shared.gypi View 2 chunks +5 lines, -0 lines 0 comments Download
MM ppapi/proxy/interface_list.cc View 2 chunks +2 lines, -0 lines 0 comments Download
MM ppapi/proxy/ppapi_messages.h View 2 chunks +18 lines, -0 lines 0 comments Download
A + ppapi/proxy/ppb_audio_input_proxy.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ppapi/proxy/ppb_audio_input_proxy.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
MM ppapi/proxy/resource_creation_proxy.h View 2 chunks +8 lines, -0 lines 0 comments Download
MM ppapi/proxy/resource_creation_proxy.cc View 2 chunks +17 lines, -0 lines 0 comments Download
MM ppapi/shared_impl/api_id.h View 1 chunk +1 line, -0 lines 0 comments Download
A + ppapi/shared_impl/audio_input_impl.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ppapi/shared_impl/audio_input_impl.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
MM ppapi/shared_impl/resource.h View 1 chunk +3 lines, -1 line 0 comments Download
MM ppapi/thunk/interfaces_ppb_public_dev.h View 2 chunks +3 lines, -0 lines 0 comments Download
A + ppapi/thunk/ppb_audio_input_api.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ppapi/thunk/ppb_audio_input_thunk.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ppapi/thunk/ppb_audio_input_trusted_thunk.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
MM ppapi/thunk/resource_creation_api.h View 2 chunks +8 lines, -1 line 0 comments Download
MM ppapi/thunk/thunk.h View 2 chunks +3 lines, -0 lines 0 comments Download
M webkit/glue/webkit_glue.gypi View 2 chunks +4 lines, -0 lines 0 comments Download
A + webkit/plugins/ppapi/audio_helper.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webkit/plugins/ppapi/audio_helper.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
MM webkit/plugins/ppapi/mock_plugin_delegate.h View 1 chunk +5 lines, -1 line 0 comments Download
MM webkit/plugins/ppapi/mock_plugin_delegate.cc View 1 chunk +8 lines, -1 line 0 comments Download
MM webkit/plugins/ppapi/plugin_delegate.h View 3 chunks +38 lines, -12 lines 0 comments Download
MM webkit/plugins/ppapi/plugin_module.cc View 3 chunks +4 lines, -0 lines 0 comments Download
MM webkit/plugins/ppapi/ppb_audio_impl.h View 4 chunks +6 lines, -19 lines 0 comments Download
MM webkit/plugins/ppapi/ppb_audio_impl.cc View 3 chunks +9 lines, -61 lines 0 comments Download
A + webkit/plugins/ppapi/ppb_audio_input_impl.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webkit/plugins/ppapi/ppb_audio_input_impl.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
MM webkit/plugins/ppapi/resource_creation_impl.h View 1 chunk +7 lines, -1 line 0 comments Download
MM webkit/plugins/ppapi/resource_creation_impl.cc View 2 chunks +15 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
viettrungluu
9 years, 1 month ago (2011-11-18 00:13:07 UTC) #1
awong
9 years, 1 month ago (2011-11-18 00:22:13 UTC) #2
LGTM rubber stamp

On Thu, Nov 17, 2011 at 4:13 PM, <viettrungluu@chromium.org> wrote:

> Reviewers: awong,
>
> Description:
> Revert 110602 - Revert 110587 - Microphone support for Pepper Flash.
>
> [I think the Windows shared builders just need to be clobbered.]
>
> [Committing for pbrophy@adobe.com. Original review:
>
http://codereview.chromium.**org/8138008/<http://codereview.chromium.org/8138...
>
> This change supports audio capture from the microphone and supplies the
> data
> through a Pepper interface. Its enumeration is limited to the default audio
> device that uses mono 44.1kHz.
>
> TBR=tony@chromium.org
>
> Review URL:
http://codereview.chromium.**org/8574029<http://codereview.chromium.org/8574029>
>
> TBR=viettrungluu@chromium.org
> Review URL:
http://codereview.chromium.**org/8569003<http://codereview.chromium.org/8569003>
>
> TBR=ajwong@chromium.org
>
> Please review this at
http://codereview.chromium.**org/8561003/<http://codereview.chromium.org/8561...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src/<http://svn.chromium.org/chrome/trunk/src/>
>
> Affected files:
>  M     content/renderer/pepper_**plugin_delegate_impl.h
>  M     content/renderer/pepper_**plugin_delegate_impl.cc
>  A  +  ppapi/api/dev/ppb_audio_input_**dev.idl
>  A  +  ppapi/api/trusted/ppb_audio_**input_trusted_dev.idl
>  A  +  ppapi/c/dev/ppb_audio_input_**dev.h
>  A  +  ppapi/c/trusted/ppb_audio_**input_trusted_dev.h
>  A  +  ppapi/cpp/dev/audio_input_dev.**h
>  A  +  ppapi/cpp/dev/audio_input_dev.**cc
>  MM    ppapi/ppapi_cpp.gypi
>  MM    ppapi/ppapi_proxy.gypi
>  MM    ppapi/ppapi_shared.gypi
>  MM    ppapi/proxy/interface_list.cc
>  MM    ppapi/proxy/ppapi_messages.h
>  A  +  ppapi/proxy/ppb_audio_input_**proxy.h
>  A  +  ppapi/proxy/ppb_audio_input_**proxy.cc
>  MM    ppapi/proxy/resource_creation_**proxy.h
>  MM    ppapi/proxy/resource_creation_**proxy.cc
>  MM    ppapi/shared_impl/api_id.h
>  A  +  ppapi/shared_impl/audio_input_**impl.h
>  A  +  ppapi/shared_impl/audio_input_**impl.cc
>  MM    ppapi/shared_impl/resource.h
>  MM    ppapi/thunk/interfaces_ppb_**public_dev.h
>  A  +  ppapi/thunk/ppb_audio_input_**api.h
>  A  +  ppapi/thunk/ppb_audio_input_**thunk.cc
>  A  +  ppapi/thunk/ppb_audio_input_**trusted_thunk.cc
>  MM    ppapi/thunk/resource_creation_**api.h
>  MM    ppapi/thunk/thunk.h
>  M     webkit/glue/webkit_glue.gypi
>  A  +  webkit/plugins/ppapi/audio_**helper.h
>  A  +  webkit/plugins/ppapi/audio_**helper.cc
>  MM    webkit/plugins/ppapi/mock_**plugin_delegate.h
>  MM    webkit/plugins/ppapi/mock_**plugin_delegate.cc
>  MM    webkit/plugins/ppapi/plugin_**delegate.h
>  MM    webkit/plugins/ppapi/plugin_**module.cc
>  MM    webkit/plugins/ppapi/ppb_**audio_impl.h
>  MM    webkit/plugins/ppapi/ppb_**audio_impl.cc
>  A  +  webkit/plugins/ppapi/ppb_**audio_input_impl.h
>  A  +  webkit/plugins/ppapi/ppb_**audio_input_impl.cc
>  MM    webkit/plugins/ppapi/resource_**creation_impl.h
>  MM    webkit/plugins/ppapi/resource_**creation_impl.cc
>
>
>

Powered by Google App Engine
This is Rietveld 408576698