Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: client/html/src/ElementWrappingImplementation.dart

Issue 8561002: Revert "Fix some type warnings in html library." (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « client/html/release/html.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: client/html/src/ElementWrappingImplementation.dart
diff --git a/client/html/src/ElementWrappingImplementation.dart b/client/html/src/ElementWrappingImplementation.dart
index e27f189721f744a64fecb67cd5904519d879679f..c30d01e68b2244494634cba5dbdbc1e02d8ece54 100644
--- a/client/html/src/ElementWrappingImplementation.dart
+++ b/client/html/src/ElementWrappingImplementation.dart
@@ -447,15 +447,15 @@ class ElementRectWrappingImplementation implements ElementRect {
// TODO(jacobr): should we move these outside of ElementRect to avoid the
// overhead of computing them every time even though they are rarely used.
// This should be type dom.ClientRect but that fails on dartium. b/5522629
- final _boundingClientRect;
+ final _boundingClientRect;
// an exception due to a dartium bug.
final dom.ClientRectList _clientRects;
ElementRectWrappingImplementation(dom.HTMLElement element) :
client = new SimpleClientRect(element.clientLeft,
element.clientTop,
- element.clientWidth,
- element.clientHeight),
+ element.clientWidth,
+ element.clientHeight),
offset = new SimpleClientRect(element.offsetLeft,
element.offsetTop,
element.offsetWidth,
@@ -480,7 +480,7 @@ class ElementRectWrappingImplementation implements ElementRect {
}
class ElementWrappingImplementation extends NodeWrappingImplementation implements Element {
-
+
static final _START_TAG_REGEXP = const RegExp('<(\\w+)');
static final _CUSTOM_PARENT_TAG_MAP = const {
'body' : 'html',
@@ -497,7 +497,7 @@ class ElementWrappingImplementation extends NodeWrappingImplementation implement
'track' : 'audio',
};
- factory Element.html(String html) {
+ factory ElementWrappingImplementation.html(String html) {
// TODO(jacobr): this method can be made more robust and performant.
// 1) Cache the dummy parent elements required to use innerHTML rather than
// creating them every call.
@@ -513,11 +513,11 @@ class ElementWrappingImplementation extends NodeWrappingImplementation implement
parentTag = _CUSTOM_PARENT_TAG_MAP[tag];
}
}
- dom.HTMLElement temp = dom.document.createElement(parentTag);
+ final temp = dom.document.createElement(parentTag);
temp.innerHTML = html;
if (temp.childElementCount == 1) {
- return LevelDom.wrapElement(temp.firstElementChild);
+ return LevelDom.wrapElement(temp.firstElementChild);
} else if (parentTag == 'html' && temp.childElementCount == 2) {
// Work around for edge case in WebKit and possibly other browsers where
// both body and head elements are created even though the inner html
@@ -528,7 +528,7 @@ class ElementWrappingImplementation extends NodeWrappingImplementation implement
}
}
- factory Element.tag(String tag) {
+ factory ElementWrappingImplementation.tag(String tag) {
return LevelDom.wrapElement(dom.document.createElement(tag));
}
@@ -710,7 +710,7 @@ class ElementWrappingImplementation extends NodeWrappingImplementation implement
}
void set scrollLeft(int value) { _ptr.scrollLeft = value; }
-
+
void set scrollTop(int value) { _ptr.scrollTop = value; }
Future<ElementRect> get rect() {
« no previous file with comments | « client/html/release/html.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698