Issue 8561001: MIPS: Check that address given to __ RecordWrite is correct.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8561001: MIPS: Check that address given to __ RecordWrite is correct. (Closed)

Created:
9 years, 1 month ago by kisg

Modified:
8 years, 10 months ago

Reviewers:
Paul Lind, Erik Corry, danno

CC:
v8-dev

Visibility:
Public.

Description

MIPS: Check that address given to __ RecordWrite is correct. Port r9963 (a8c30ef3). This port uses Abort() instead of stop() to avoid timeouts during testing and also get the error message on native MIPS targets. BUG= TEST=

Patch Set 1 #

Patch Set 2 : Rebased on r10041 #

Patch Set 3 : Rebased on r10145 #

Patch Set 4 : Rebased on r10294 #

Patch Set 5 : Rebased on r10351 #

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
	M	src/mips/macro-assembler-mips.cc	View	1 2 3	1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

kisg

In order to compile, this patch requires the following patch to be applied first: http://codereview.chromium.org/8557003/

9 years, 1 month ago (2011-11-13 21:21:57 UTC) #1

Erik Corry

8 years, 11 months ago (2012-01-10 13:45:23 UTC) #5

Sorry about the delay.

I rolled this one into http://codereview.chromium.org/9168006
 which is now committed.

Expand Messages | Collapse Messages