Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Issue 8560003: AddRemove is failing the same way as TabbedPaneTest.SizeAndLayout on win7. (Closed)

Created:
9 years, 1 month ago by Nicolas Sylvain
Modified:
9 years, 1 month ago
CC:
chromium-reviews, tfarina, dhollowa, Paweł Hajdan Jr.
Visibility:
Public.

Description

AddRemove is failing the same way as TabbedPaneTest.SizeAndLayout on win7. I'm also disabling it. BUG:104067 TBR:mnissler Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109836

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M views/controls/tabbed_pane/tabbed_pane_unittest.cc View 2 chunks +4 lines, -2 lines 1 comment Download

Messages

Total messages: 3 (0 generated)
Nicolas Sylvain
9 years, 1 month ago (2011-11-13 18:07:57 UTC) #1
nsylvain
http://codereview.chromium.org/8560003/diff/1/views/controls/tabbed_pane/tabbed_pane_unittest.cc File views/controls/tabbed_pane/tabbed_pane_unittest.cc (right): http://codereview.chromium.org/8560003/diff/1/views/controls/tabbed_pane/tabbed_pane_unittest.cc#newcode72 views/controls/tabbed_pane/tabbed_pane_unittest.cc:72: #define MAYBE_AddRemove DISBLED_AddRemove DISBLED->DISABLED. already fixed.
9 years, 1 month ago (2011-11-13 19:30:11 UTC) #2
Mattias Nissler (ping if slow)
9 years, 1 month ago (2011-11-14 08:41:09 UTC) #3
lgtm

Powered by Google App Engine
This is Rietveld 408576698