Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 8559003: Pepper: Generate ppb_flash_clipboard.h from .idl file. (Closed)

Created:
9 years, 1 month ago by viettrungluu
Modified:
9 years, 1 month ago
CC:
chromium-reviews
Visibility:
Public.

Description

Pepper: Generate ppb_flash_clipboard.h from .idl file. Also, convert the version number for the PPB_Flash_Clipboard interface to the standard form. BUG=104001, 104184 TEST=(The existing) Pepper Flash still works. TBR=dmichael@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109999

Patch Set 1 #

Patch Set 2 : ready? #

Total comments: 4

Patch Set 3 : fix whitespace #

Unified diffs Side-by-side diffs Delta from patch set Stats (+168 lines, -22 lines) Patch
A ppapi/api/private/ppb_flash_clipboard.idl View 1 2 1 chunk +83 lines, -0 lines 0 comments Download
M ppapi/c/private/ppb_flash_clipboard.h View 1 2 1 chunk +72 lines, -13 lines 0 comments Download
M ppapi/proxy/interface_list.cc View 1 2 chunks +11 lines, -9 lines 0 comments Download
M webkit/plugins/ppapi/plugin_module.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
noelallen1
One nit about comment space, otherwise LGTM http://codereview.chromium.org/8559003/diff/2001/ppapi/api/private/ppb_flash_clipboard.idl File ppapi/api/private/ppb_flash_clipboard.idl (right): http://codereview.chromium.org/8559003/diff/2001/ppapi/api/private/ppb_flash_clipboard.idl#newcode17 ppapi/api/private/ppb_flash_clipboard.idl:17: * The ...
9 years, 1 month ago (2011-11-14 21:33:37 UTC) #1
viettrungluu
Thanks. http://codereview.chromium.org/8559003/diff/2001/ppapi/api/private/ppb_flash_clipboard.idl File ppapi/api/private/ppb_flash_clipboard.idl (right): http://codereview.chromium.org/8559003/diff/2001/ppapi/api/private/ppb_flash_clipboard.idl#newcode17 ppapi/api/private/ppb_flash_clipboard.idl:17: * The old version string for this interface, ...
9 years, 1 month ago (2011-11-14 21:37:59 UTC) #2
commit-bot: I haz the power
No LGTM from valid reviewers yet.
9 years, 1 month ago (2011-11-14 22:04:48 UTC) #3
viettrungluu
+dmichael, OWNERS TBR
9 years, 1 month ago (2011-11-15 00:35:30 UTC) #4
dmichael (off chromium)
9 years, 1 month ago (2011-11-15 17:52:09 UTC) #5
lgtm

Powered by Google App Engine
This is Rietveld 408576698