Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8558032: Add OVERRIDE to chrome/test/. (Closed)

Created:
9 years, 1 month ago by Avi (use Gerrit)
Modified:
9 years, 1 month ago
Reviewers:
sky
CC:
chromium-reviews, kkania, Paweł Hajdan Jr.
Visibility:
Public.

Description

Add OVERRIDE to chrome/test/. BUG=104314 TEST=no change Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110793

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+231 lines, -224 lines) Patch
M chrome/test/base/browser_with_test_window_test.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/chrome_render_view_test.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/base/chrome_test_suite.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/base/menu_model_test.h View 1 chunk +6 lines, -4 lines 0 comments Download
M chrome/test/base/test_url_request_context_getter.h View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/test/base/testing_profile.h View 4 chunks +82 lines, -78 lines 0 comments Download
M chrome/test/base/ui_test_utils.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/reliability/automated_ui_test_base.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/reliability/automated_ui_tests.h View 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/test/ui/npapi_test_helper.h View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/test/ui/ui_test.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/test/ui/ui_test_suite.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/webdriver/commands/alert_commands.h View 3 chunks +8 lines, -8 lines 0 comments Download
M chrome/test/webdriver/commands/appcache_status_command.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/webdriver/commands/browser_connection_commands.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/webdriver/commands/cookie_commands.h View 2 chunks +9 lines, -9 lines 0 comments Download
M chrome/test/webdriver/commands/create_session.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/webdriver/commands/execute_async_script_command.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/webdriver/commands/execute_command.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/webdriver/commands/find_element_commands.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/webdriver/commands/mouse_commands.h View 9 chunks +15 lines, -15 lines 0 comments Download
M chrome/test/webdriver/commands/navigate_commands.h View 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/test/webdriver/commands/screenshot_command.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/webdriver/commands/session_with_id.h View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/test/webdriver/commands/set_timeout_commands.h View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/test/webdriver/commands/source_command.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/webdriver/commands/target_locator_commands.h View 5 chunks +12 lines, -12 lines 0 comments Download
M chrome/test/webdriver/commands/title_command.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/webdriver/commands/url_command.h View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/test/webdriver/commands/webdriver_command.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/webdriver/commands/webelement_commands.h View 16 chunks +35 lines, -35 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Avi (use Gerrit)
Owner approval? Just added OVERRIDEs. Nothing more.
9 years, 1 month ago (2011-11-18 23:38:42 UTC) #1
sky
9 years, 1 month ago (2011-11-19 00:05:58 UTC) #2 
Rubber stamp LGTM
Feel free to TBR these sort of things in the future.

Powered by Google App Engine
This is Rietveld 408576698