Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(434)

Issue 8558031: [Aura] Refactor and update app list window. (Closed)

Created:
9 years, 1 month ago by xiyuan
Modified:
9 years, 1 month ago
Reviewers:
sky
CC:
chromium-reviews, Ben Goodger (Google)
Visibility:
Public.

Description

[Aura] Refactor and update app list window. - Move showing, dimissing, animation observer, click monitoring code tha into an AppList controller in aura_shell; - Change ShellDelegate::ShowApps to an inteface to request app list widget and having a callback to notify app list controller when the widget is ready; - Click outside to dismiss the window. - Hide default container when app list is visible; BUG=98308 TEST=Verify click outside applist window to dismiss it. Browser windows should be hidden when app list window is shown and should be visible when app list is gone. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111021

Patch Set 1 #

Total comments: 2

Patch Set 2 : sync, wqmove SetWidgetCallback into ShellDelegate #

Patch Set 3 : sync, change initial size close to final size to avoid CardSlider resize animation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+332 lines, -149 lines) Patch
M chrome/browser/ui/views/aura/app_list_window.h View 1 3 chunks +5 lines, -32 lines 0 comments Download
M chrome/browser/ui/views/aura/app_list_window.cc View 1 2 7 chunks +9 lines, -109 lines 0 comments Download
M chrome/browser/ui/views/aura/chrome_shell_delegate.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/aura/chrome_shell_delegate.cc View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
A ui/aura_shell/app_list.h View 1 chunk +83 lines, -0 lines 0 comments Download
A ui/aura_shell/app_list.cc View 1 chunk +175 lines, -0 lines 0 comments Download
M ui/aura_shell/aura_shell.gyp View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M ui/aura_shell/examples/aura_shell_main.cc View 1 2 chunks +33 lines, -2 lines 0 comments Download
M ui/aura_shell/launcher/launcher_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/aura_shell/shell.h View 3 chunks +6 lines, -0 lines 0 comments Download
M ui/aura_shell/shell.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M ui/aura_shell/shell_delegate.h View 1 3 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
xiyuan
Refactoring idea is from Ben so that we keep aura_shell internal code in aura_shell. Besides ...
9 years, 1 month ago (2011-11-18 23:31:52 UTC) #1
sky
LGTM http://codereview.chromium.org/8558031/diff/1/ui/aura_shell/shell_delegate.h File ui/aura_shell/shell_delegate.h (right): http://codereview.chromium.org/8558031/diff/1/ui/aura_shell/shell_delegate.h#newcode19 ui/aura_shell/shell_delegate.h:19: typedef base::Callback<void(views::Widget*)> SetWidgetCallback; Move this inside of ShellDelegate.
9 years, 1 month ago (2011-11-19 00:13:14 UTC) #2
xiyuan
http://codereview.chromium.org/8558031/diff/1/ui/aura_shell/shell_delegate.h File ui/aura_shell/shell_delegate.h (right): http://codereview.chromium.org/8558031/diff/1/ui/aura_shell/shell_delegate.h#newcode19 ui/aura_shell/shell_delegate.h:19: typedef base::Callback<void(views::Widget*)> SetWidgetCallback; On 2011/11/19 00:13:14, sky wrote: > ...
9 years, 1 month ago (2011-11-19 00:25:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xiyuan@chromium.org/8558031/11001
9 years, 1 month ago (2011-11-21 18:37:23 UTC) #4
commit-bot: I haz the power
Try job failure for 8558031-11001 (retry) on mac_rel for step "ui_tests". It's a second try, ...
9 years, 1 month ago (2011-11-21 20:49:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xiyuan@chromium.org/8558031/11001
9 years, 1 month ago (2011-11-21 21:08:34 UTC) #6
commit-bot: I haz the power
9 years, 1 month ago (2011-11-21 22:52:46 UTC) #7
Change committed as 111021

Powered by Google App Engine
This is Rietveld 408576698