Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(447)

Issue 8558026: Remove TSan suppression that has been fixed by moving plugin dlopen()ing out-of-process. (Closed)

Created:
9 years, 1 month ago by Robert Sesek
Modified:
9 years, 1 month ago
Reviewers:
cbentzel
CC:
chromium-reviews, Timur Iskhodzhanov, Alexander Potapenko, pam+watch_chromium.org, stuartmorgan+watch_chromium.org
Visibility:
Public.

Description

Remove TSan suppression that has been fixed by moving plugin dlopen()ing out-of-process. BUG=93757 TEST=TSan Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110918

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -19 lines) Patch
M tools/valgrind/tsan/suppressions.txt View 1 chunk +0 lines, -19 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Robert Sesek
9 years, 1 month ago (2011-11-18 19:23:26 UTC) #1
cbentzel
9 years, 1 month ago (2011-11-18 19:25:08 UTC) #2
LGTM

On Fri, Nov 18, 2011 at 2:23 PM, <rsesek@chromium.org> wrote:

> Reviewers: cbentzel,
>
> Description:
> Remove TSan suppression that has been fixed by moving plugin dlopen()ing
> out-of-process.
>
> BUG=93757
> TEST=TSan
>
>
> Please review this at
http://codereview.chromium.**org/8558026/<http://codereview.chromium.org/8558...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>  M tools/valgrind/tsan/**suppressions.txt
>
>
> Index: tools/valgrind/tsan/**suppressions.txt
> diff --git a/tools/valgrind/tsan/**suppressions.txt b/tools/valgrind/tsan/
> **suppressions.txt
> index 29b762ff6e720398858f2915eecbad**57a3a46cd4..**
> ac5617586e2e9df6709b0eaae41eb7**df55924841 100644
> --- a/tools/valgrind/tsan/**suppressions.txt
> +++ b/tools/valgrind/tsan/**suppressions.txt
> @@ -507,25 +507,6 @@
>   fun:ThreadWatcherList::**InitializeAndStartWatching
>  }
>  {
> -  bug_93757_a
> -  ThreadSanitizer:Race
> -  fun:__memset_sse2
> -  fun:VisitedLinkMaster::**CreateURLTable
> -}
> -{
> -  bug_93757_b
> -  ThreadSanitizer:Race
> -  ...
> -  fun:webkit::npapi::PluginLib::**ReadWebPluginInfo
> -  fun:webkit::npapi::PluginList:**:ReadPluginInfo
> -  fun:webkit::npapi::PluginList:**:LoadPlugin
> -  fun:webkit::npapi::PluginList:**:LoadPluginsFromDir
> -  fun:webkit::npapi::PluginList:**:LoadPluginsInternal
> -  fun:webkit::npapi::PluginList:**:LoadPlugins
> -  fun:webkit::npapi::PluginList:**:GetPlugins
> -  fun:PluginService::**GetPluginsInternal
> -}
> -{
>   bug_93932_a
>   ThreadSanitizer:Race
>   ...
>
>
>

Powered by Google App Engine
This is Rietveld 408576698