Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 8558020: Protector strings and bubble/SettingsChange code refactoring. (Closed)

Created:
9 years, 1 month ago by Ivan Korotkov
Modified:
9 years, 1 month ago
Reviewers:
whywhat
CC:
chromium-reviews
Visibility:
Public.

Description

Protector strings and bubble/SettingsChange code refactoring. BUG=102765, 103317 TEST=Manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110910

Patch Set 1 #

Patch Set 2 : Win build fix. #

Patch Set 3 : Fix Windows build (now for real). #

Patch Set 4 : This time it really should compile. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+331 lines, -275 lines) Patch
M chrome/app/generated_resources.grd View 1 2 1 chunk +33 lines, -33 lines 0 comments Download
A chrome/browser/protector/base_setting_change.h View 1 2 3 1 chunk +67 lines, -0 lines 0 comments Download
A chrome/browser/protector/base_setting_change.cc View 1 2 1 chunk +25 lines, -0 lines 0 comments Download
M chrome/browser/protector/default_search_provider_change.cc View 1 2 3 3 chunks +142 lines, -47 lines 0 comments Download
M chrome/browser/protector/protector.h View 1 2 4 chunks +11 lines, -11 lines 0 comments Download
M chrome/browser/protector/protector.cc View 1 2 2 chunks +24 lines, -16 lines 0 comments Download
M chrome/browser/protector/setting_change.h View 1 2 1 chunk +0 lines, -73 lines 0 comments Download
M chrome/browser/protector/settings_change_global_error.h View 1 2 4 chunks +9 lines, -10 lines 0 comments Download
M chrome/browser/protector/settings_change_global_error.cc View 1 2 3 4 chunks +15 lines, -80 lines 0 comments Download
M chrome/browser/protector/settings_change_global_error_delegate.h View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/search_engines/template_url_service.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 2 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Ivan Korotkov
9 years, 1 month ago (2011-11-18 16:06:51 UTC) #1
whywhat
lgtm
9 years, 1 month ago (2011-11-18 16:09:16 UTC) #2
Ivan Korotkov
9 years, 1 month ago (2011-11-21 13:34:22 UTC) #3
Yep, this finally compiled under Win.

Powered by Google App Engine
This is Rietveld 408576698