Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4433)

Unified Diff: chrome/browser/protector/setting_change.h

Issue 8558016: Revert 110685 - Fix Clang error on SettingChange. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/protector/setting_change.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/protector/setting_change.h
===================================================================
--- chrome/browser/protector/setting_change.h (revision 110687)
+++ chrome/browser/protector/setting_change.h (working copy)
@@ -21,19 +21,19 @@
// Base class for setting change tracked by Protector.
class SettingChange {
public:
- SettingChange();
- virtual ~SettingChange();
+ SettingChange() {}
+ virtual ~SettingChange() {}
// Applies initial actions to the setting if needed. Must be called before
// any other calls are made, including text getters. Returns true if
// initialization was successful.
- virtual bool Init(Protector* protector);
+ virtual bool Init(Protector* protector) { return true; }
// Persists new setting if needed.
- virtual void Apply(Protector* protector);
+ virtual void Apply(Protector* protector) {}
// Restores old setting if needed.
- virtual void Discard(Protector* protector);
+ virtual void Discard(Protector* protector) {}
// Returns the wrench menu item and bubble title.
virtual string16 GetTitle() const = 0;
« no previous file with comments | « no previous file | chrome/browser/protector/setting_change.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698