Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 8558015: Added chrome.experimental.devtools.panels.createStatusBarButton() (Closed)

Created:
9 years, 1 month ago by caseq
Modified:
9 years, 1 month ago
CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, mihaip+watch_chromium.org
Visibility:
Public.

Description

Added chrome.experimental.devtools.panels.createStatusBarButton() BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111164

Patch Set 1 #

Total comments: 1

Patch Set 2 : removed duplicate the #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1543 lines, -443 lines) Patch
M chrome/common/extensions/api/devtools_api.json View 1 5 chunks +75 lines, -1 line 1 comment Download
M chrome/common/extensions/docs/experimental.devtools.panels.html View 1 40 chunks +1468 lines, -442 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
caseq1
This documents a couple of recent API changes: - added callbacks for ExtensionSidebarPane.set{Expression|Object}() - added ...
9 years, 1 month ago (2011-11-18 13:01:12 UTC) #1
mkearney
Just a small comment. http://codereview.chromium.org/8558015/diff/1/chrome/common/extensions/api/devtools_api.json File chrome/common/extensions/api/devtools_api.json (right): http://codereview.chromium.org/8558015/diff/1/chrome/common/extensions/api/devtools_api.json#newcode327 chrome/common/extensions/api/devtools_api.json:327: "description": "A callback invoked after ...
9 years, 1 month ago (2011-11-18 18:56:51 UTC) #2
caseq1
On 2011/11/18 18:56:51, mkearney wrote: > Remove extra 'the'. Ouch. Fixed. That must be me ...
9 years, 1 month ago (2011-11-21 18:33:08 UTC) #3
mkearney
lgtm
9 years, 1 month ago (2011-11-21 19:12:27 UTC) #4
kathyw
A few nits... http://codereview.chromium.org/8558015/diff/5001/chrome/common/extensions/api/devtools_api.json File chrome/common/extensions/api/devtools_api.json (right): http://codereview.chromium.org/8558015/diff/5001/chrome/common/extensions/api/devtools_api.json#newcode237 chrome/common/extensions/api/devtools_api.json:237: "description": "Path to the icon of ...
9 years, 1 month ago (2011-11-21 19:55:46 UTC) #5
caseq1
9 years, 1 month ago (2011-11-22 16:36:58 UTC) #6
On 2011/11/21 19:55:46, kathyw wrote:
> A few nits...

Thanks! Landed with these fixed.

Powered by Google App Engine
This is Rietveld 408576698