Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 8558010: clang fails compile on aura drag and drop code (Closed)

Created:
9 years, 1 month ago by dhollowa
Modified:
9 years, 1 month ago
Reviewers:
sky, varunjain
CC:
chromium-reviews, dcheng
Visibility:
Public.

Description

clang fails compile on aura drag and drop code clang check for non-trivial destructors in headers. BUG=none TEST=compiles on mac clang R=varunjain@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110799

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M ui/base/dragdrop/os_exchange_data_provider_aura.h View 1 chunk +1 line, -2 lines 0 comments Download
M ui/base/dragdrop/os_exchange_data_provider_aura.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
dhollowa
9 years, 1 month ago (2011-11-18 03:05:54 UTC) #1
varunjain
Lgtm On 2011/11/18 03:05:54, dhollowa wrote:
9 years, 1 month ago (2011-11-18 06:00:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dhollowa@chromium.org/8558010/1
9 years, 1 month ago (2011-11-18 16:56:26 UTC) #3
commit-bot: I haz the power
Presubmit check for 8558010-1 failed and returned exit status 1. Running presubmit commit checks ...
9 years, 1 month ago (2011-11-18 16:56:33 UTC) #4
dhollowa
+sky for OWNERS approval.
9 years, 1 month ago (2011-11-18 22:40:11 UTC) #5
sky
LGTM
9 years, 1 month ago (2011-11-18 22:45:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dhollowa@chromium.org/8558010/1
9 years, 1 month ago (2011-11-18 22:54:01 UTC) #7
commit-bot: I haz the power
9 years, 1 month ago (2011-11-19 00:37:40 UTC) #8
Try job failure for 8558010-1 (retry) (retry) on linux_rel for step "ui_tests".
It's a second try, previously, steps "check_deps, ui_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

Powered by Google App Engine
This is Rietveld 408576698