Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(459)

Issue 8558009: Add -supported command line option to describe if a given file is supported (Closed)

Created:
9 years, 1 month ago by dgarrett
Modified:
9 years, 1 month ago
Reviewers:
Michael Krebs, sra1, adlr
CC:
chromium-reviews
Visibility:
Public.

Description

Add -supported command line option to describe if a given file is supported and what type of executable it is, if it is. BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110993

Patch Set 1 #

Patch Set 2 : Add return value for -supported #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -9 lines) Patch
M courgette/courgette.h View 2 chunks +0 lines, -2 lines 0 comments Download
M courgette/courgette_tool.cc View 1 5 chunks +51 lines, -7 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
dgarrett
9 years, 1 month ago (2011-11-18 02:31:28 UTC) #1
sra1
My only though is that the 'supported' status could find its way to the exit ...
9 years, 1 month ago (2011-11-18 07:35:22 UTC) #2
sra1
lgtm
9 years, 1 month ago (2011-11-18 07:35:40 UTC) #3
dgarrett
I think you are right about the exit code. Adding that now.
9 years, 1 month ago (2011-11-18 18:25:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgarrett@chromium.org/8558009/4001
9 years, 1 month ago (2011-11-18 18:55:48 UTC) #5
commit-bot: I haz the power
Try job failure for 8558009-4001 (retry) on linux_rel for step "ui_tests". It's a second try, ...
9 years, 1 month ago (2011-11-18 20:23:19 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgarrett@chromium.org/8558009/4001
9 years, 1 month ago (2011-11-18 21:28:14 UTC) #7
commit-bot: I haz the power
Try job failure for 8558009-4001 (retry) on linux_rel for step "ui_tests". It's a second try, ...
9 years, 1 month ago (2011-11-18 22:34:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgarrett@chromium.org/8558009/4001
9 years, 1 month ago (2011-11-21 19:17:40 UTC) #9
commit-bot: I haz the power
9 years, 1 month ago (2011-11-21 20:26:58 UTC) #10
Change committed as 110993

Powered by Google App Engine
This is Rietveld 408576698