Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Side by Side Diff: chrome/browser/ui/views/window.h

Issue 8557005: Rebase the MessageBubble on the new views bubble. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address comments. Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_VIEWS_WINDOW_H_ 5 #ifndef CHROME_BROWSER_UI_VIEWS_WINDOW_H_
6 #define CHROME_BROWSER_UI_VIEWS_WINDOW_H_ 6 #define CHROME_BROWSER_UI_VIEWS_WINDOW_H_
7 #pragma once 7 #pragma once
8 8
9 #include "ui/gfx/native_widget_types.h" 9 #include "ui/gfx/native_widget_types.h"
10 10
(...skipping 10 matching lines...) Expand all
21 views::WidgetDelegate* delegate); 21 views::WidgetDelegate* delegate);
22 22
23 // Create a bubble for a given |delegate|. Takes care of chromeos 23 // Create a bubble for a given |delegate|. Takes care of chromeos
24 // specific window type setting if needed. 24 // specific window type setting if needed.
25 views::Widget* CreateViewsBubble(views::BubbleDelegateView* delegate); 25 views::Widget* CreateViewsBubble(views::BubbleDelegateView* delegate);
26 26
27 // Create a bubble that will show even when chromeos screen is locked, 27 // Create a bubble that will show even when chromeos screen is locked,
28 // for a given |delegate|. Takes care of chromeos specific window 28 // for a given |delegate|. Takes care of chromeos specific window
29 // type setting. For bubbles that do not need to be shown when screen 29 // type setting. For bubbles that do not need to be shown when screen
30 // is locked, use CreateViewsBubble instead. 30 // is locked, use CreateViewsBubble instead.
31 views::Widget* CreateViewsBubbleAboveLockScreen( 31 views::Widget* CreateViewsBubbleAboveLockScreen(
Nikita (slow) 2011/11/29 13:08:37 In general I don't think that every bubble should
msw 2011/11/29 19:49:52 Most bubbles use |CreateViewsBubble|, not |CreateV
32 views::BubbleDelegateView* delegate); 32 views::BubbleDelegateView* delegate);
33
33 } // namespace browser 34 } // namespace browser
34 35
35 #endif // CHROME_BROWSER_UI_VIEWS_WINDOW_H_ 36 #endif // CHROME_BROWSER_UI_VIEWS_WINDOW_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698