content/browser/device_orientation/provider_impl.h - Issue 8556001: Convert NewRunnableFunction/NewRunnableMethod calls to use base::Bind().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/device_orientation/provider_impl.h

Issue 8556001: Convert NewRunnableFunction/NewRunnableMethod calls to use base::Bind(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: . Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/browser_message_filter.cc ('K') | « content/browser/child_process_launcher.cc ('k') | content/browser/device_orientation/provider_impl.cc » ('j') | content/browser/net/url_request_failed_dns_job.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/device_orientation/provider_impl.h

diff --git a/content/browser/device_orientation/provider_impl.h b/content/browser/device_orientation/provider_impl.h

index db05d315d7db53b3ba5bae4731627f8b78391fd3..46c2bfe66a9fb3aa78ab9d22ddd56b80e6eb812f 100644

--- a/content/browser/device_orientation/provider_impl.h

+++ b/content/browser/device_orientation/provider_impl.h

@@ -9,7 +9,7 @@

#include <vector>

#include "base/memory/scoped_ptr.h"

-#include "base/task.h"

+#include "base/memory/weak_ptr.h"

#include "content/browser/device_orientation/data_fetcher.h"

#include "content/browser/device_orientation/orientation.h"

#include "content/browser/device_orientation/provider.h"

@@ -76,7 +76,7 @@ class ProviderImpl : public Provider {

// from that thread.

scoped_ptr<DataFetcher> data_fetcher_;

Orientation last_orientation_;

- ScopedRunnableMethodFactory<ProviderImpl> do_poll_method_factory_;

+ base::WeakPtrFactory<ProviderImpl> do_poll_method_factory_;

James Hawkins 2011/11/14 17:57:06 s/do_poll_method_factory/weak_factory_/

dcheng 2011/11/14 20:47:49 Done.

// Polling is done on this background thread.

scoped_ptr<base::Thread> polling_thread_;