Convert NewRunnableFunction/NewRunnableMethod calls to use base::Bind().

Convert NewRunnableFunction/NewRunnableMethod calls to use base::Bind().

BUG=none
TEST=compiles and tests pass.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110164

[James Hawkins, 2011-11-14 17:57:06]

http://codereview.chromium.org/8556001/diff/4001/content/browser/browser_mess...
File content/browser/browser_message_filter.cc (right):

http://codereview.chromium.org/8556001/diff/4001/content/browser/browser_mess...
content/browser/browser_message_filter.cc:53: base::IgnoreReturn<bool>(
#include "base/bind_helpers.h"

http://codereview.chromium.org/8556001/diff/4001/content/browser/device_orien...
File content/browser/device_orientation/provider_impl.h (right):

http://codereview.chromium.org/8556001/diff/4001/content/browser/device_orien...
content/browser/device_orientation/provider_impl.h:79:
base::WeakPtrFactory<ProviderImpl> do_poll_method_factory_;
s/do_poll_method_factory/weak_factory_/

http://codereview.chromium.org/8556001/diff/4001/content/browser/net/url_requ...
File content/browser/net/url_request_failed_dns_job.h (right):

http://codereview.chromium.org/8556001/diff/4001/content/browser/net/url_requ...
content/browser/net/url_request_failed_dns_job.h:35:
base::WeakPtrFactory<URLRequestFailedDnsJob> method_factory_;
weak_factory_

http://codereview.chromium.org/8556001/diff/4001/content/browser/net/url_requ...
File content/browser/net/url_request_slow_download_job.h (right):

http://codereview.chromium.org/8556001/diff/4001/content/browser/net/url_requ...
content/browser/net/url_request_slow_download_job.h:75:
base::WeakPtrFactory<URLRequestSlowDownloadJob> method_factory_;
weak_factory_

http://codereview.chromium.org/8556001/diff/4001/content/browser/renderer_hos...
File content/browser/renderer_host/pepper_message_filter.cc (right):

http://codereview.chromium.org/8556001/diff/4001/content/browser/renderer_hos...
content/browser/renderer_host/pepper_message_filter.cc:1094:
!base::WorkerPool::PostTask(FROM_HERE,
nit: Parameter lines should all start on the same column, here and below.

http://codereview.chromium.org/8556001/diff/4001/content/browser/renderer_hos...
File content/browser/renderer_host/render_message_filter.cc (right):

http://codereview.chromium.org/8556001/diff/4001/content/browser/renderer_hos...
content/browser/renderer_host/render_message_filter.cc:807: BrowserThread::IO,
FROM_HERE, base::IgnoreReturn<bool>(base::Bind(
#include "base/bind_helpers.h"

http://codereview.chromium.org/8556001/diff/4001/content/browser/renderer_hos...
File content/browser/renderer_host/resource_dispatcher_host.h (right):

http://codereview.chromium.org/8556001/diff/4001/content/browser/renderer_hos...
content/browser/renderer_host/resource_dispatcher_host.h:473:
base::WeakPtrFactory<ResourceDispatcherHost> method_runner_;
weak_factory_

http://codereview.chromium.org/8556001/diff/4001/content/browser/utility_proc...
File content/browser/utility_process_host.cc (right):

http://codereview.chromium.org/8556001/diff/4001/content/browser/utility_proc...
content/browser/utility_process_host.cc:143: base::IgnoreReturn<bool>(
#include "base/bind_helpers.h"

http://codereview.chromium.org/8556001/diff/4001/content/common/resource_disp...
File content/common/resource_dispatcher.h (right):

http://codereview.chromium.org/8556001/diff/4001/content/common/resource_disp...
content/common/resource_dispatcher.h:157:
base::WeakPtrFactory<ResourceDispatcher> method_factory_;
weak_factory_

http://codereview.chromium.org/8556001/diff/4001/content/common/webmessagepor...
File content/common/webmessageportchannel_impl.cc (right):

http://codereview.chromium.org/8556001/diff/4001/content/common/webmessagepor...
content/common/webmessageportchannel_impl.cc:82:
ChildThread::current()->message_loop()->PostTask(FROM_HERE,
Start of parameters must be on the same column.

http://codereview.chromium.org/8556001/diff/4001/content/test/test_url_fetche...
File content/test/test_url_fetcher_factory.cc (right):

http://codereview.chromium.org/8556001/diff/4001/content/test/test_url_fetche...
content/test/test_url_fetcher_factory.cc:269:
base::WeakPtrFactory<FakeURLFetcher> method_factory_;
weak_factory_

http://codereview.chromium.org/8556001/diff/4001/content/worker/webworkerclie...
File content/worker/webworkerclient_proxy.h (right):

http://codereview.chromium.org/8556001/diff/4001/content/worker/webworkerclie...
content/worker/webworkerclient_proxy.h:97:
base::WeakPtrFactory<WebWorkerClientProxy> kill_process_factory_;
weak_factory_

[dcheng, 2011-11-14 20:47:49]

http://codereview.chromium.org/8556001/diff/4001/content/browser/browser_mess...
File content/browser/browser_message_filter.cc (right):

http://codereview.chromium.org/8556001/diff/4001/content/browser/browser_mess...
content/browser/browser_message_filter.cc:53: base::IgnoreReturn<bool>(
On 2011/11/14 17:57:06, James Hawkins wrote:
> #include "base/bind_helpers.h"

Done.

http://codereview.chromium.org/8556001/diff/4001/content/browser/device_orien...
File content/browser/device_orientation/provider_impl.h (right):

http://codereview.chromium.org/8556001/diff/4001/content/browser/device_orien...
content/browser/device_orientation/provider_impl.h:79:
base::WeakPtrFactory<ProviderImpl> do_poll_method_factory_;
On 2011/11/14 17:57:06, James Hawkins wrote:
> s/do_poll_method_factory/weak_factory_/

Done.

http://codereview.chromium.org/8556001/diff/4001/content/browser/net/url_requ...
File content/browser/net/url_request_failed_dns_job.h (right):

http://codereview.chromium.org/8556001/diff/4001/content/browser/net/url_requ...
content/browser/net/url_request_failed_dns_job.h:35:
base::WeakPtrFactory<URLRequestFailedDnsJob> method_factory_;
On 2011/11/14 17:57:06, James Hawkins wrote:
> weak_factory_

Done.

http://codereview.chromium.org/8556001/diff/4001/content/browser/net/url_requ...
File content/browser/net/url_request_slow_download_job.h (right):

http://codereview.chromium.org/8556001/diff/4001/content/browser/net/url_requ...
content/browser/net/url_request_slow_download_job.h:75:
base::WeakPtrFactory<URLRequestSlowDownloadJob> method_factory_;
On 2011/11/14 17:57:06, James Hawkins wrote:
> weak_factory_

Done.

http://codereview.chromium.org/8556001/diff/4001/content/browser/renderer_hos...
File content/browser/renderer_host/pepper_message_filter.cc (right):

http://codereview.chromium.org/8556001/diff/4001/content/browser/renderer_hos...
content/browser/renderer_host/pepper_message_filter.cc:1094:
!base::WorkerPool::PostTask(FROM_HERE,
On 2011/11/14 17:57:06, James Hawkins wrote:
> nit: Parameter lines should all start on the same column, here and below.

Done.

http://codereview.chromium.org/8556001/diff/4001/content/browser/renderer_hos...
File content/browser/renderer_host/render_message_filter.cc (right):

http://codereview.chromium.org/8556001/diff/4001/content/browser/renderer_hos...
content/browser/renderer_host/render_message_filter.cc:807: BrowserThread::IO,
FROM_HERE, base::IgnoreReturn<bool>(base::Bind(
On 2011/11/14 17:57:06, James Hawkins wrote:
> #include "base/bind_helpers.h"

Done.

http://codereview.chromium.org/8556001/diff/4001/content/browser/renderer_hos...
File content/browser/renderer_host/resource_dispatcher_host.h (right):

http://codereview.chromium.org/8556001/diff/4001/content/browser/renderer_hos...
content/browser/renderer_host/resource_dispatcher_host.h:473:
base::WeakPtrFactory<ResourceDispatcherHost> method_runner_;
On 2011/11/14 17:57:06, James Hawkins wrote:
> weak_factory_

Done.

http://codereview.chromium.org/8556001/diff/4001/content/browser/utility_proc...
File content/browser/utility_process_host.cc (right):

http://codereview.chromium.org/8556001/diff/4001/content/browser/utility_proc...
content/browser/utility_process_host.cc:143: base::IgnoreReturn<bool>(
On 2011/11/14 17:57:06, James Hawkins wrote:
> #include "base/bind_helpers.h"

Done.

http://codereview.chromium.org/8556001/diff/4001/content/common/resource_disp...
File content/common/resource_dispatcher.h (right):

http://codereview.chromium.org/8556001/diff/4001/content/common/resource_disp...
content/common/resource_dispatcher.h:157:
base::WeakPtrFactory<ResourceDispatcher> method_factory_;
On 2011/11/14 17:57:06, James Hawkins wrote:
> weak_factory_

Done.

http://codereview.chromium.org/8556001/diff/4001/content/common/webmessagepor...
File content/common/webmessageportchannel_impl.cc (right):

http://codereview.chromium.org/8556001/diff/4001/content/common/webmessagepor...
content/common/webmessageportchannel_impl.cc:82:
ChildThread::current()->message_loop()->PostTask(FROM_HERE,
On 2011/11/14 17:57:06, James Hawkins wrote:
> Start of parameters must be on the same column.

Done.

http://codereview.chromium.org/8556001/diff/4001/content/test/test_url_fetche...
File content/test/test_url_fetcher_factory.cc (right):

http://codereview.chromium.org/8556001/diff/4001/content/test/test_url_fetche...
content/test/test_url_fetcher_factory.cc:269:
base::WeakPtrFactory<FakeURLFetcher> method_factory_;
On 2011/11/14 17:57:06, James Hawkins wrote:
> weak_factory_

Done.

http://codereview.chromium.org/8556001/diff/4001/content/worker/webworkerclie...
File content/worker/webworkerclient_proxy.h (right):

http://codereview.chromium.org/8556001/diff/4001/content/worker/webworkerclie...
content/worker/webworkerclient_proxy.h:97:
base::WeakPtrFactory<WebWorkerClientProxy> kill_process_factory_;
On 2011/11/14 17:57:06, James Hawkins wrote:
> weak_factory_

Done.

[James Hawkins, 2011-11-14 20:50:34]

lgtm

[dcheng, 2011-11-14 22:29:16]

Adding jam@ for OWNERS review. I believe the test failures to be unrelated to
this change.

[jam, 2011-11-15 00:15:34]

lgtm

[dcheng, 2011-11-15 00:52:06]

+willchan. I didn't realize content/browser/net was noparent.

[willchan no longer on Chromium, 2011-11-15 15:51:25]

content/browser/net LGTM