Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1835)

Unified Diff: chrome/common/extensions/docs/server/chromeextensionsdocs.py

Issue 8555032: Fix directory traversal issue in extension doc server. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/extensions/docs/server/app.yaml ('k') | chrome/common/extensions/docs/server/index.yaml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/docs/server/chromeextensionsdocs.py
diff --git a/chrome/common/extensions/docs/server/chromeextensionsdocs.py b/chrome/common/extensions/docs/server/chromeextensionsdocs.py
index a15de088bc463a5595dcd0e9878ad63e7010e294..db9585552cc1df6b34b046f71d826e36b4e81179 100644
--- a/chrome/common/extensions/docs/server/chromeextensionsdocs.py
+++ b/chrome/common/extensions/docs/server/chromeextensionsdocs.py
@@ -72,7 +72,9 @@ class MainPage(webapp.RequestHandler):
logging.info("Path: " + self.request.path)
logging.info("Url: " + url)
try:
- result = urlfetch.fetch(url + self.request.query_string)
+ # TODO(aa): Do we need to pass the querystring through here? We used to,
Mihai Parparita -not on Chrome 2011/11/15 14:44:49 You could also switch this to url + '?' + self.req
Aaron Boodman 2011/11/15 19:06:57 Aha! In that case, I'm comfortable just removing t
+ # but that caused problems. See crbug.com/104272.
+ result = urlfetch.fetch(url)
if result.status_code != 200:
logging.error("urlfetch failed: " + url)
# TODO(nickbaum): what should we do when the urlfetch fails?
« no previous file with comments | « chrome/common/extensions/docs/server/app.yaml ('k') | chrome/common/extensions/docs/server/index.yaml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698