Removed clipped bottom padding from chrome://flags and chrome://plugins headers.

Removed clipped bottom padding from chrome://flags and chrome://plugins headers.

This padding isn't shown; however it causes the headings to jump up when a find is
executed which matches anything in the headers. The referenced chrome bug contains
details on reproducing the problem; the webkit fix is non-trivial and possibly
controversial.

BUG=83292
TEST=Checked pages look the same


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110938

[benwells, 2011-11-17 04:57:43]

Anyone care to look at this?

[James Hawkins, 2011-11-20 23:33:07]

http://codereview.chromium.org/8555030/diff/1/chrome/browser/resources/plugin...
File chrome/browser/resources/plugins.css (right):

http://codereview.chromium.org/8555030/diff/1/chrome/browser/resources/plugin...
chrome/browser/resources/plugins.css:254: }
What's the change here?  I can't see it in this form.

[benwells, 2011-11-21 00:32:45]

http://codereview.chromium.org/8555030/diff/1/chrome/browser/resources/plugin...
File chrome/browser/resources/plugins.css (right):

http://codereview.chromium.org/8555030/diff/1/chrome/browser/resources/plugin...
chrome/browser/resources/plugins.css:254: }
On 2011/11/20 23:33:08, James Hawkins wrote:
> What's the change here?  I can't see it in this form.

The original file doesn't have a CR after the closing brace, the new version
does.

[James Hawkins, 2011-11-21 00:39:41]

The reduction in padding of 23px seems somewhat arbitrary.  Can you explain what
the problem is and how this solves it?

[benwells, 2011-11-21 00:53:41]

On 2011/11/21 00:39:41, James Hawkins wrote:
> The reduction in padding of 23px seems somewhat arbitrary.  Can you explain
what
> the problem is and how this solves it?

Sure thing. The see the problem:
- go to either chrome://flags or chrome://plugins
- ctrl-f to bring up the find box
- type s
- observe the title and its image, it jumps up.

It does this because webkit 'scrolls' the contents of the containing div so it
is in visible, including padding which is clipped by overflow: hidden.

The padding was reduced to match the bottom padding of the containing div
(div#header). This makes it so there is no padding which is clipped, without
causing any visible appearance in the pages.

It would be great to get this fixed in WebKit but its not certain how that
should happen. The proposed fix is a simple workaround to fix the visible
manifestation of the problem.

[James Hawkins, 2011-11-21 00:55:53]

Gotcha, thanks. LGTM

[James Hawkins, 2011-11-21 00:55:55]

Gotcha, thanks. LGTM

[commit-bot: I haz the power, 2011-11-21 01:07:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/benwells@chromium.org/8555030/1

[commit-bot: I haz the power, 2011-11-21 16:49:56]

Change committed as 110938

[arv (Not doing code reviews), 2011-11-21 19:44:01]

LGTM

[Nico, 2012-06-22 03:49:31]

This broke the look of the icon in the upper left corner on about:flags and
about:plugins. These icons are now cut off at the bottom. That's a lot worse
than the heading jumping on find. Can you take a look?

(ps: It looks like the bug # in the BUG= line is wrong.)

[benwells, 2012-06-22 07:28:09]

On 2012/06/22 03:49:31, Nico wrote:
> This broke the look of the icon in the upper left corner on about:flags and
> about:plugins. These icons are now cut off at the bottom. That's a lot worse
> than the heading jumping on find. Can you take a look?
> 
> (ps: It looks like the bug # in the BUG= line is wrong.)

OK I'll take a look. The correct bug is http://crbug.com/83282