Issue 8555027: Tests for WebUI Hung Renderer Dialog

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8555027: Tests for WebUI Hung Renderer Dialog (Closed)

Created:
9 years, 1 month ago by wyck

Modified:
9 years, 1 month ago

Reviewers:
flackr

CC:
chromium-reviews, arv (Not doing code reviews), Paweł Hajdan Jr.

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Tests for WebUI Hung Renderer Dialog Adds a WebUIBrowserTest for WebUI Hung Renderer Dialog. Also modifies HungRendererDialog to allow it to be called in a test without killing processes or restarting hang timers. Fixed revert issue with win_aura. BUG=102073 TEST=browser_tests HungRendererDialogUITest.* Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110082

Patch Set 1 #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+212 lines, -28 lines)			Patch
M	chrome/browser/resources/hung_renderer_dialog.js	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/webui/hung_renderer_dialog.h	View	3 chunks	+35 lines, -1 line	0 comments	Download
M	chrome/browser/ui/webui/hung_renderer_dialog.cc	View	5 chunks	+57 lines, -25 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View	1 chunk	+2 lines, -0 lines	0 comments	Download
A	chrome/test/data/webui/hung_renderer_dialog_test.js	View	1 chunk	+63 lines, -0 lines	0 comments	Download
A	chrome/test/data/webui/hung_renderer_dialog_ui_test-inl.h	View	1 chunk	+53 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

wyck

Third time's a charm, right? See http://codereview.chromium.org/8462015 for what's different between this and that. One ...

9 years, 1 month ago (2011-11-15 01:58:30 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wyck@chromium.org/8555027/1

9 years, 1 month ago (2011-11-15 13:49:17 UTC) #3

Change committed as 110082

Expand Messages | Collapse Messages