aura: Draw drop shadows under browsers and menus.

views/widget/native_widget_aura.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "views/widget/native_widget_aura.h"
 
 #include "base/bind.h"
 #include "ui/aura/client/aura_constants.h"
 #include "ui/aura/desktop.h"
 #include "ui/aura/desktop_observer.h"
@@ skipping 138 matching lines @@
   }
   // TODO(beng): do this some other way.
   delegate_->OnNativeWidgetSizeChanged(params.bounds.size());
   can_activate_ = params.can_activate;
   if (params.type != Widget::InitParams::TYPE_TOOLTIP && !params.child) {
     DCHECK(GetWidget()->GetRootView());
     views::TooltipManagerViews* manager = new views::TooltipManagerViews(
         GetWidget()->GetRootView());
     tooltip_manager_.reset(manager);
   }
+
+  if (window_type == Widget::InitParams::TYPE_MENU)
+    window_->SetShadowVisible(true);

[Daniel Erat, 2011/11/15 01:05:04]

Doing this from Views seems a bit gross to me.  Opinions about this?

[sky, 2011/11/15 04:49:13]

Why? This seems like the right place to me. The other option is to have a type
in window (or in a property on window), which doesn't feel right either.

 }

[sky, 2011/11/15 04:50:40]

One more comment here. Are we really going to only have the shadow on menus?
Seems like we would want it normal windows too. That said, I'm sure going that
route would have serious performance implications. Maybe add the ability to turn
it on via a flag?

[Daniel Erat, 2011/11/15 17:52:58]

Yes, they're getting enabled in browser_frame_aura.cc.

 
 NonClientFrameView* NativeWidgetAura::CreateNonClientFrameView() {
   return NULL;
 }
 
 void NativeWidgetAura::UpdateFrameAfterFrameChange() {
   // We don't support changing the frame type.
   NOTREACHED();
 }
 
@@ skipping 552 matching lines @@
   NOTIMPLEMENTED();
 }
 
 // static
 bool NativeWidgetPrivate::IsMouseButtonDown() {
   return aura::Desktop::GetInstance()->IsMouseButtonDown();
 }
 
 }  // namespace internal
 }  // namespace views