vm/globals.h - Issue 8555024: - Avoid allocating variable length arrays on the stack.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: vm/globals.h

Issue 8555024: - Avoid allocating variable length arrays on the stack. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/

Patch Set: '' Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: vm/globals.h

===================================================================

--- vm/globals.h (revision 1537)

+++ vm/globals.h (working copy)

@@ -315,7 +315,9 @@

inline D bit_copy(const S& source) {

D destination;

// This use of memcpy is safe: source and destination cannot overlap.

- memcpy(&destination, &source, sizeof(destination));

+ memcpy(&destination,

+ reinterpret_cast<const void*>(&source),

+ sizeof(destination));

return destination;

}

« no previous file with comments | « bin/process_macos.cc ('k') | vm/port.cc » ('j') | no next file with comments »