- Avoid allocating variable length arrays on the stack.

vm/globals.h

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef VM_GLOBALS_H_
 #define VM_GLOBALS_H_
 
 // __STDC_FORMAT_MACROS has to be defined to enable platform independent printf.
 #ifndef __STDC_FORMAT_MACROS
 #define __STDC_FORMAT_MACROS
@@ skipping 297 matching lines @@
 
 // Similar to bit_cast, but allows copying from types of unrelated
 // sizes. This method was introduced to enable the strict aliasing
 // optimizations of GCC 4.4. Basically, GCC mindlessly relies on
 // obscure details in the C++ standard that make reinterpret_cast
 // virtually useless.
 template<class D, class S>
 inline D bit_copy(const S& source) {
   D destination;
   // This use of memcpy is safe: source and destination cannot overlap.
-  memcpy(&destination, &source, sizeof(destination));
+  memcpy(&destination,
+         reinterpret_cast<const void*>(&source),
+         sizeof(destination));
   return destination;
 }
 
 // A macro to ensure that memcpy cannot be called. memcpy does not handle
 // overlapping memory regions. Even though this is well documented it seems
 // to be used in error quite often. To avoid problems we disallow the direct
 // use of memcpy here.
 //
 // On Windows the basic libraries use memcpy and therefore compilation will
 // fail if memcpy is overwritten even if user code does not use memcpy.
 #if defined(memcpy)
 #undef memcpy
 #endif
 #if !defined(TARGET_OS_WINDOWS)
 #define memcpy "Please use memmove instead of memcpy."
 #endif
 
 
 // When using GCC we can use GCC attributes to ensure that certain
 // contants are 16 byte aligned.
 #if defined(TARGET_OS_WINDOWS)
 #define ALIGN16 __declspec(align(16))
 #else
 #define ALIGN16 __attribute__((aligned(16)))
 #endif
 
 }  // namespace dart
 
 #endif  // VM_GLOBALS_H_