Increased battery time to empty sent by power manager stub impl

chrome/browser/chromeos/dbus/power_manager_client.cc

Index: chrome/browser/chromeos/dbus/power_manager_client.cc
diff --git a/chrome/browser/chromeos/dbus/power_manager_client.cc b/chrome/browser/chromeos/dbus/power_manager_client.cc
index dc9761d64cc6623ba667637f98eaf099ba5efada..f31ee8aa4f1d634b33378861628ad4556a6ad202 100644
--- a/chrome/browser/chromeos/dbus/power_manager_client.cc
+++ b/chrome/browser/chromeos/dbus/power_manager_client.cc
@@ -311,8 +311,10 @@ class PowerManagerClientStubImpl : public PowerManagerClient {
     status.line_power_on = !discharging_;
     status.battery_is_present = true;
     status.battery_percentage = battery_percentage_;
+    // We don't want to go to low because we don't want a low battery
+    // notification to pop up.
     status.battery_seconds_to_empty =
-        std::max(1, battery_percentage_ * 180 / 100);
+        std::max(16, battery_percentage_ * 180 / 100);

[satorux1, 2011/11/14 22:03:05]

Why did we end up showing the low battery balloon in browser_tests from the
beginning?

Looking at the code, the battery percentage started from 80%, and decreases by 1
point every time Update() is called.

Update() is called by a repeating timer every 100 ms from the first time
RequestStatusUpdate() is called. Hence it only needed 8 seconds to drain the
battery.

I'd say 100ms is too aggressive. We could make it something like 5 seconds for
now.

Besides, the magic number 180 looks cryptic. This is the number of  seconds to
fully charge the battery, right? 180 looks unrealistically short. I think we
should define a constant with a more realistic number, like

kNumSecondsToFullyChargeBattery = 60 * 120;  // 120 mins.

[satorux1, 2011/11/14 22:10:41]

FWIW, it used to be 3 hours, but changed to 180 seconds in this patch:

http://codereview.chromium.org/8347016/diff/27003/chrome/browser/chromeos/cro...

Which is partly my fault as I wasn't able to catch the undesirable change.

     status.battery_seconds_to_full =
         std::max(static_cast<int64>(1), 180 - status.battery_seconds_to_empty);