Increased battery time to empty sent by power manager stub impl

chrome/browser/chromeos/dbus/power_manager_client.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/dbus/power_manager_client.h"
 
 #include "base/bind.h"
 #include "base/callback.h"
 #include "base/format_macros.h"
 #include "base/memory/scoped_ptr.h"
@@ skipping 229 matching lines @@
   DISALLOW_COPY_AND_ASSIGN(PowerManagerClientImpl);
 };
 
 // The PowerManagerClient implementation used on Linux desktop,
 // which does nothing.
 class PowerManagerClientStubImpl : public PowerManagerClient {
  public:
   PowerManagerClientStubImpl()
       : discharging_(true),
         battery_percentage_(80),
-        pause_count_(0) {
+        pause_count_(0),
+        kSecondsToEmptyFullBattery(3 * 60 * 60) /* 3 hours */ {

[satorux1, 2011/11/14 22:59:50]

It's awkward to make it a member variable. see below.

[tbarzic, 2011/11/14 23:05:39]

Done.

   }
 
   virtual ~PowerManagerClientStubImpl() {}
 
   // PowerManagerClient override.
   virtual void AddObserver(Observer* observer) OVERRIDE {
     observers_.AddObserver(observer);
   }
 
   // PowerManagerClient override.
   virtual void RemoveObserver(Observer* observer) OVERRIDE {
     observers_.RemoveObserver(observer);
   }
 
   // PowerManagerClient override.
   virtual void DecreaseScreenBrightness(bool allow_off) OVERRIDE {
     VLOG(1) << "Requested to descrease screen brightness";
   }
 
   // PowerManagerClient override.
   virtual void IncreaseScreenBrightness() OVERRIDE {
     VLOG(1) << "Requested to increase screen brightness";
   }
 
   virtual void RequestStatusUpdate() OVERRIDE {
     if (!timer_.IsRunning()) {
       timer_.Start(
           FROM_HERE,
-          base::TimeDelta::FromMilliseconds(100),
+          base::TimeDelta::FromMilliseconds(200),
           this,
           &PowerManagerClientStubImpl::Update);
     } else {
       timer_.Stop();
     }
   }
 
   virtual void RequestRestart() OVERRIDE {}
 
   virtual void RequestShutdown() OVERRIDE {}
 
  private:
   void Update() {
     // We pause at 0 and 100% so that it's easier to check those conditions.
     if (pause_count_ > 1) {
       pause_count_--;
       return;
     }
 
     if (battery_percentage_ == 0 || battery_percentage_ == 100) {
       if (pause_count_) {
         pause_count_ = 0;
         discharging_ = !discharging_;
       } else {
-        pause_count_ = 20;
+        pause_count_ = 10;
         return;
       }
     }
     battery_percentage_ += (discharging_ ? -1 : 1);
 
     PowerSupplyStatus status;

[satorux1, 2011/11/14 22:59:50]

You can define the constant here:

const int kSecondsToEmptyFullBattery = 3 * 60 * 60;

Alternatively, you can define this in anonymous namespace.

[tbarzic, 2011/11/14 23:05:39]

Done.

     status.line_power_on = !discharging_;
     status.battery_is_present = true;
     status.battery_percentage = battery_percentage_;
     status.battery_seconds_to_empty =
-        std::max(1, battery_percentage_ * 180 / 100);
+        std::max(1, battery_percentage_ * kSecondsToEmptyFullBattery / 100);
     status.battery_seconds_to_full =
-        std::max(static_cast<int64>(1), 180 - status.battery_seconds_to_empty);
+        std::max(static_cast<int64>(1),
+                 kSecondsToEmptyFullBattery - status.battery_seconds_to_empty);
 
     FOR_EACH_OBSERVER(Observer, observers_, PowerChanged(status));
   }
 
   bool discharging_;
   int battery_percentage_;
   int pause_count_;
+  const int kSecondsToEmptyFullBattery;
   ObserverList<Observer> observers_;
   base::RepeatingTimer<PowerManagerClientStubImpl> timer_;
 };
 
 PowerManagerClient::PowerManagerClient() {
 }
 
 PowerManagerClient::~PowerManagerClient() {
 }
 
 PowerManagerClient* PowerManagerClient::Create(dbus::Bus* bus) {
   if (system::runtime_environment::IsRunningOnChromeOS()) {
     return new PowerManagerClientImpl(bus);
   } else {
     return new PowerManagerClientStubImpl();
   }
 }
 
 }  // namespace chromeos