Issue 8555017: Add --no-seh to linker command line when building Windows FFmpeg binaries.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8555017: Add --no-seh to linker command line when building Windows FFmpeg binaries. (Closed)

Created:
9 years, 1 month ago by scherkus (not reviewing)

Modified:
9 years, 1 month ago

Reviewers:
acolwell GONE FROM CHROMIUM, jschuh

CC:
chromium-reviews

Base URL:
svn://chrome-svn/chrome/trunk/deps/third_party/ffmpeg/

Visibility:
Public.

More Reviews

Description

Add --no-seh to linker command line when building Windows FFmpeg binaries. Instead of trying to define an empty SEH table in the LOAD_CONFIG section we can set IMAGE_DLLCHARACTERISTICS_NO_SEH in the NT headers. BUG=99901 TEST=Run BinScope on the new FFmpeg binaries, the SafeSEHCheck test should pass Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109946

Patch Set 1 #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1 line, -0 lines)			Patch
M	binaries/win/avcodec-53.dll	View	Binary file		0 comments	Download
M	binaries/win/avformat-53.dll	View	Binary file		0 comments	Download
M	binaries/win/avutil-51.dll	View	Binary file		0 comments	Download
M	build_ffmpeg.sh	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

jschuh

9 years, 1 month ago (2011-11-14 20:31:31 UTC) #2

On 2011/11/14 20:28:50, scherkus wrote:

lgtm. Please make sure to mark the m16 binaries as well.

Expand Messages | Collapse Messages