Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Unified Diff: chrome/browser/resources/policy.html

Issue 8555009: Fix display and progressive disclosure for multi-line values in about:policy. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address comments. Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/policy.css ('k') | chrome/browser/resources/policy.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/policy.html
diff --git a/chrome/browser/resources/policy.html b/chrome/browser/resources/policy.html
index 8f7349e4b04c7d2626339c6b8f4dd6435dc58311..e904b46291c31b925d685500998c0fc93026e357 100644
--- a/chrome/browser/resources/policy.html
+++ b/chrome/browser/resources/policy.html
@@ -127,24 +127,26 @@
<span class="policy-name" jscontent="name"></span>
</td>
<td>
- <div class="text-container collapsed">
- <span class="cell-text" jscontent="value"></span>
+ <div class="text-collapsed text-container">
+ <button class="link-button toggler expand"
+ i18n-content="showMoreText" hidden></button>
+ <div class="text-cell">
+ <span class="text-value" jscontent="value"></span>
+ </div>
+ <button class="link-button toggler collapse"
+ i18n-content="hideText" hidden></button>
</div>
- <a class="toggler expand" style="display: none"
- jsdisplay="Policy.shouldShowExpand(this)"
- i18n-content="showMoreText"></a>
- <a class="toggler collapse" style="display: none"
- i18n-content="hideText"></a>
</td>
<td>
- <div class="text-container collapsed">
- <span class="cell-text" jscontent="status"></span>
+ <div class="text-collapsed text-container">
+ <button class="link-button toggler expand"
+ i18n-content="showMoreText" hidden></button>
+ <div class="text-cell">
+ <span class="text-value" jscontent="status"></span>
+ </div>
+ <button class="link-button toggler collapse"
+ i18n-content="hideText" hidden></button>
</div>
- <a class="toggler expand" style="display: none"
- jsdisplay="Policy.shouldShowExpand(this)"
- i18n-content="showMoreText"></a>
- <a class="toggler collapse" style="display: none"
- i18n-content="hideText"></a>
</td>
</tr>
</table>
« no previous file with comments | « chrome/browser/resources/policy.css ('k') | chrome/browser/resources/policy.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698