chrome/browser/policy/policy_error_map.cc - Issue 8555009: Fix display and progressive disclosure for multi-line values in about:policy.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/policy/policy_error_map.cc

Issue 8555009: Fix display and progressive disclosure for multi-line values in about:policy. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address comments, make hide/show proper links. Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/policy/policy_error_map.cc

diff --git a/chrome/browser/policy/policy_error_map.cc b/chrome/browser/policy/policy_error_map.cc

index 956392a6ab661624eab57d1b9b7ad53d771c2d6f..daf167a25af39df13af324990039c5adc4fa6319 100644

--- a/chrome/browser/policy/policy_error_map.cc

+++ b/chrome/browser/policy/policy_error_map.cc

@@ -57,7 +57,7 @@ string16 PolicyErrorMap::GetErrors(ConfigurationPolicyType policy) {

std::vector<string16> list;

for (const_iterator it = range.first; it != range.second; ++it)

list.push_back(it->second);

- return JoinString(list, ' ');

+ return JoinString(list, '\n');

}

bool PolicyErrorMap::empty() {

« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/resources/policy.css » ('j') | chrome/browser/resources/policy.html » ('J')