Issue 8555005: Mark SessionHistoryTest.FrameBackForward flaky on Mac.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8555005: Mark SessionHistoryTest.FrameBackForward flaky on Mac. (Closed)

Created:
9 years, 1 month ago by Jói

Modified:
9 years ago

Reviewers:
Finnur, Nico

CC:
chromium-reviews, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Mark SessionHistoryTest.FrameBackForward flaky on Mac. BUG=61619 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109869

Patch Set 1 #

Total comments: 1

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/browser/session_history_uitest.cc	View		1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Jói

Couldn't find an appropriate reviewer from git blame, so the guy sitting next to me ...

9 years, 1 month ago (2011-11-14 12:31:12 UTC) #1

Finnur

LGTM. First-one-to-move-to-Iceland-gets-to-sit-next-to-Joi... :)

9 years, 1 month ago (2011-11-14 12:35:41 UTC) #2

Nico

http://codereview.chromium.org/8555005/diff/1/chrome/browser/session_history_uitest.cc File chrome/browser/session_history_uitest.cc (right): http://codereview.chromium.org/8555005/diff/1/chrome/browser/session_history_uitest.cc#newcode149 chrome/browser/session_history_uitest.cc:149: #if defined(OS_WIN) || defined(OS_MAC) It's OS_MAXOSX, not OS_MAC. Since ...

9 years ago (2011-12-01 16:50:31 UTC) #3

Jói

9 years ago (2011-12-01 17:08:29 UTC) #4

On 2011/12/01 16:50:31, Nico wrote:
>
http://codereview.chromium.org/8555005/diff/1/chrome/browser/session_history_...
> File chrome/browser/session_history_uitest.cc (right):
> 
>
http://codereview.chromium.org/8555005/diff/1/chrome/browser/session_history_...
> chrome/browser/session_history_uitest.cc:149: #if defined(OS_WIN) ||
> defined(OS_MAC)
> It's OS_MAXOSX, not OS_MAC. Since there are no complaints, maybe that can just
> be removed? The bug is marked fixed, maybe it can be removed on win as well?

Good catch, I did a couple of these last time I sheriffed where I used OS_MAC
but thought I had fixed them all.

I will remove the flaky mark for both platforms and we'll just see if it comes
back.

Cheers,
Jói

Expand Messages | Collapse Messages