Added NaCl proxy for TCP/UDP

ppapi/native_client/src/shared/ppapi_proxy/browser_ppb_udp_socket_private_rpc_server.cc

Index: ppapi/native_client/src/shared/ppapi_proxy/browser_ppb_udp_socket_private_rpc_server.cc
diff --git a/ppapi/native_client/src/shared/ppapi_proxy/browser_ppb_udp_socket_private_rpc_server.cc b/ppapi/native_client/src/shared/ppapi_proxy/browser_ppb_udp_socket_private_rpc_server.cc
new file mode 100644
index 0000000000000000000000000000000000000000..3109e9b2a98fba27ed832dbd6cb39e67fefad68b
--- /dev/null
+++ b/ppapi/native_client/src/shared/ppapi_proxy/browser_ppb_udp_socket_private_rpc_server.cc
@@ -0,0 +1,230 @@
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+//
+// SRPC-abstraction wrappers around PPB_UDPSocket_Private functions.
+
+#include <string.h>
+#include <limits>
+
+#include "native_client/src/include/nacl_macros.h"
+#include "native_client/src/shared/ppapi_proxy/browser_callback.h"
+#include "native_client/src/shared/ppapi_proxy/browser_globals.h"
+#include "native_client/src/shared/ppapi_proxy/utility.h"
+#include "ppapi/c/pp_completion_callback.h"
+#include "ppapi/c/pp_errors.h"
+#include "ppapi/c/private/ppb_udp_socket_private.h"
+#include "srpcgen/ppb_rpc.h"
+
+using ppapi_proxy::DebugPrintf;
+using ppapi_proxy::DeleteRemoteCallbackInfo;
+using ppapi_proxy::MakeRemoteCompletionCallback;
+using ppapi_proxy::PPBUDPSocketPrivateInterface;
+
+void PpbUDPSocketPrivateServer::PPB_UDPSocket_Private_Create(

[polina, 2011/11/29 05:20:47]

As mentioned earlier, as per our convention, the name should be PpbFooRpcServer,
not PpbFooServer.

[ygorshenin, 2011/11/29 13:25:18]

Done.

+    NaClSrpcRpc* rpc,
+    NaClSrpcClosure* done,
+    // input
+    PP_Instance instance_id,
+    // output
+    PP_Resource* resource) {
+  NaClSrpcClosureRunner runner(done);
+  rpc->result = NACL_SRPC_RESULT_OK;
+
+  *resource = PPBUDPSocketPrivateInterface()->Create(instance_id);
+
+  DebugPrintf("PPB_UDPSocket_Private::Create: "
+              "resource=%"NACL_PRIu32"\n", *resource);
+}
+
+void PpbUDPSocketPrivateServer::PPB_UDPSocket_Private_IsUDPSocket(
+    NaClSrpcRpc* rpc,
+    NaClSrpcClosure* done,
+    // input
+    PP_Resource resource_id,
+    // output
+    int32_t* is_udp_socket_private) {

[polina, 2011/11/29 05:20:47]

As mentioned earlier, "private" should be removed.

[ygorshenin, 2011/11/29 13:25:18]

Done.

+  NaClSrpcClosureRunner runner(done);
+  rpc->result = NACL_SRPC_RESULT_OK;
+
+  PP_Bool pp_success =
+      PPBUDPSocketPrivateInterface()->IsUDPSocket(resource_id);
+
+  DebugPrintf("PPB_UDPSocket_Private::IsUDPSocket: "
+              "pp_success=%d\n", pp_success);
+
+  *is_udp_socket_private = (pp_success == PP_TRUE);
+}
+
+void PpbUDPSocketPrivateServer::PPB_UDPSocket_Private_Bind(
+    NaClSrpcRpc* rpc,
+    NaClSrpcClosure* done,
+    // input
+    PP_Resource udp_socket,
+    nacl_abi_size_t addr_bytes, char* addr,
+    int32_t callback_id,
+    // output
+    int32_t* pp_error) {
+  NaClSrpcClosureRunner runner(done);
+  rpc->result = NACL_SRPC_RESULT_APP_ERROR;
+
+  if (addr_bytes != sizeof(PP_NetAddress_Private))
+    return;
+
+  PP_CompletionCallback remote_callback =
+      MakeRemoteCompletionCallback(rpc->channel, callback_id);
+  if (NULL == remote_callback.func)
+    return;
+
+  *pp_error = PPBUDPSocketPrivateInterface()->Bind(
+      udp_socket,
+      reinterpret_cast<const struct PP_NetAddress_Private*>(addr),

[polina, 2011/11/29 05:20:47]

As mentioned earlier, you should not need const, should you?

[ygorshenin, 2011/11/29 13:25:18]

Done.

+      remote_callback);
+
+  DebugPrintf("PPB_UDPSocket_Private::Bind: "
+              "pp_error=%"NACL_PRId32"\n", *pp_error);
+
+  if (*pp_error != PP_OK_COMPLETIONPENDING)  // Async error.
+    DeleteRemoteCallbackInfo(remote_callback);
+  rpc->result = NACL_SRPC_RESULT_OK;
+}
+
+void PpbUDPSocketPrivateServer::PPB_UDPSocket_Private_RecvFrom(
+    NaClSrpcRpc* rpc,
+    NaClSrpcClosure* done,
+    // input
+    PP_Resource udp_socket,
+    int32_t num_bytes,
+    int32_t callback_id,
+    // output
+    nacl_abi_size_t* buffer_bytes,
+    char* buffer,

[polina, 2011/11/29 05:20:47]

move to the previous line?

[ygorshenin, 2011/11/29 13:25:18]

Done.

+    int32_t* pp_error_or_bytes) {
+  NaClSrpcClosureRunner runner(done);
+  rpc->result = NACL_SRPC_RESULT_APP_ERROR;
+
+  if (!(*buffer_bytes <=
+        static_cast<nacl_abi_size_t>(std::numeric_limits<int32_t>::max())))

[polina, 2011/11/29 05:20:47]

As mentioned earlier, it should be ok to rely on the size checks done by the
ppapi implementation.

[ygorshenin, 2011/11/29 13:25:18]

Done.

+    return;
+  if (*buffer_bytes != static_cast<nacl_abi_size_t>(num_bytes))
+    return;
+
+  char* callback_buffer = NULL;
+  PP_CompletionCallback remote_callback =
+      MakeRemoteCompletionCallback(rpc->channel, callback_id, num_bytes,
+                                   &callback_buffer);
+  if (NULL == remote_callback.func)
+    return;
+
+  *pp_error_or_bytes = PPBUDPSocketPrivateInterface()->RecvFrom(
+      udp_socket,
+      callback_buffer,
+      num_bytes,
+      remote_callback);
+
+  DebugPrintf("PPB_UDPSocket_Private::RecvFrom: "
+              "pp_error_or_bytes=%"NACL_PRId32"\n", *pp_error_or_bytes);
+
+  if (!(*pp_error_or_bytes <= num_bytes))
+    return;
+
+  if (*pp_error_or_bytes > 0) {  // Bytes read into |callback_buffer|.
+    // No callback scheduled.
+    if (!(static_cast<nacl_abi_size_t>(*pp_error_or_bytes) <= *buffer_bytes))
+      return;
+    *buffer_bytes = static_cast<nacl_abi_size_t>(*pp_error_or_bytes);
+    memcpy(buffer, callback_buffer, *buffer_bytes);
+    DeleteRemoteCallbackInfo(remote_callback);
+  } else if (*pp_error_or_bytes != PP_OK_COMPLETIONPENDING) {  // Async error.
+    // No callback scheduled.
+    *buffer_bytes = 0;
+    DeleteRemoteCallbackInfo(remote_callback);
+  } else {
+    // Callback scheduled.
+    *buffer_bytes = 0;
+  }
+
+  rpc->result = NACL_SRPC_RESULT_OK;
+}
+
+void PpbUDPSocketPrivateServer::PPB_UDPSocket_Private_GetRecvFromAddress(
+    NaClSrpcRpc* rpc,
+    NaClSrpcClosure* done,
+    // input
+    PP_Resource udp_socket,
+    // output
+    nacl_abi_size_t* addr_bytes, char* addr,
+    int32_t* success) {
+  NaClSrpcClosureRunner runner(done);
+  rpc->result = NACL_SRPC_RESULT_OK;
+
+  PP_Bool pp_success =
+      PPBUDPSocketPrivateInterface()->GetRecvFromAddress(
+          udp_socket,
+          reinterpret_cast<struct PP_NetAddress_Private*>(addr));
+
+  DebugPrintf("PPB_UDPSocket_Private::GetRecvFromAddress: "
+              "pp_success=%d\n", pp_success);
+
+  *addr_bytes = static_cast<nacl_abi_size_t>(sizeof(PP_NetAddress_Private));

[polina, 2011/11/29 05:20:47]

As mentioned earlier, this should be an equality equality check in the
beginning.

[ygorshenin, 2011/11/29 13:25:18]

Done.

+  *success = (pp_success == PP_TRUE);
+}
+
+void PpbUDPSocketPrivateServer::PPB_UDPSocket_Private_SendTo(
+    NaClSrpcRpc* rpc,
+    NaClSrpcClosure* done,
+    // input
+    PP_Resource udp_socket,
+    nacl_abi_size_t buffer_bytes, char* buffer,
+    int32_t num_bytes,
+    nacl_abi_size_t addr_bytes, char* addr,
+    int32_t callback_id,
+    // output
+    int32_t* pp_error_or_bytes) {
+

[polina, 2011/11/29 05:20:47]

no blank

[ygorshenin, 2011/11/29 13:25:18]

Done.

+  NaClSrpcClosureRunner runner(done);
+  rpc->result = NACL_SRPC_RESULT_APP_ERROR;
+
+  UNREFERENCED_PARAMETER(addr_bytes);

[polina, 2011/11/29 05:20:47]

aren't you missing a sizeof check for this?

[ygorshenin, 2011/11/29 13:25:18]

Done.

+
+  if (!(buffer_bytes <=
+        static_cast<nacl_abi_size_t>(std::numeric_limits<int32_t>::max())))
+    return;

[polina, 2011/11/29 05:20:47]

same as above

[ygorshenin, 2011/11/29 13:25:18]

Done.

+  if (!(static_cast<nacl_abi_size_t>(num_bytes) <= buffer_bytes))
+    return;
+
+  PP_CompletionCallback remote_callback = MakeRemoteCompletionCallback(
+      rpc->channel, callback_id);
+  if (NULL == remote_callback.func)
+    return;
+
+  *pp_error_or_bytes =
+      PPBUDPSocketPrivateInterface()->SendTo(
+          udp_socket,
+          buffer,
+          num_bytes,
+          (const struct PP_NetAddress_Private*) addr,

[polina, 2011/11/29 05:20:47]

same as above

[polina, 2011/11/29 05:20:47]

c-style casts are against the style guide

[ygorshenin, 2011/11/29 13:25:18]

Done.

+          remote_callback);
+
+  DebugPrintf("PPB_UDPSocket_Private::SendTo: "
+              "pp_error_or_bytes=%"NACL_PRId32"\n", *pp_error_or_bytes);
+
+  // Bytes must be written asynchronously.
+  if (*pp_error_or_bytes != PP_OK_COMPLETIONPENDING)
+    DeleteRemoteCallbackInfo(remote_callback);
+  rpc->result = NACL_SRPC_RESULT_OK;
+}
+
+void PpbUDPSocketPrivateServer::PPB_UDPSocket_Private_Close(
+    NaClSrpcRpc* rpc,
+    NaClSrpcClosure* done,
+    // input
+    PP_Resource udp_socket) {
+  NaClSrpcClosureRunner runner(done);
+  rpc->result = NACL_SRPC_RESULT_OK;
+
+  DebugPrintf("PPB_UDPSocket_Private::Close: "
+              "udp_socket=%"NACL_PRIu32"\n", udp_socket);
+
+  PPBUDPSocketPrivateInterface()->Close(udp_socket);
+}