Added NaCl proxy for TCP/UDP

chrome/test/ui/ppapi_uitest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/file_util.h"
 #include "base/path_service.h"
 #include "base/test/test_timeouts.h"
 #include "build/build_config.h"
 #include "content/browser/plugin_service.h"
 #include "content/public/common/content_switches.h"
@@ skipping 181 matching lines @@
 // NaCl plugin test runner.
 class PPAPINaClTest : public PPAPITestBase {
  public:
   PPAPINaClTest() {
     FilePath plugin_lib;
     EXPECT_TRUE(PathService::Get(chrome::FILE_NACL_PLUGIN, &plugin_lib));
     EXPECT_TRUE(file_util::PathExists(plugin_lib));
 
     // Enable running NaCl outside of the store.
     launch_arguments_.AppendSwitch(switches::kEnableNaCl);
+    launch_arguments_.AppendArg("--allow-nacl-socket-api=127.0.0.1");

[polina, 2011/11/29 05:20:47]

A comment explaining what this flag is for would be helpful.

[polina, 2011/11/29 05:20:47]

Is there no switches file where this flag is defined?

[ygorshenin, 2011/11/29 13:25:18]

Yes, this flag is defined in CL http://codereview.chromium.org/8688002/, so,
this CL can't be commited and need to be merged with it. But in this case we'll
lost comments and history.

[polina, 2011/11/30 01:26:21]

Don't merge the CLs. Just commit them in the right order. This will make it
easier to isolate failures, track commit history, etc. And if you do end up
merging or moving things around, please don't forget to add references to CLs
with original comments to the new CLs' descriptions.

   }
 
   // Append the correct mode and testcase string
   std::string BuildQuery(const std::string& base,
                          const std::string& test_case) {
     return StringPrintf("%smode=nacl&testcase=%s", base.c_str(),
                         test_case.c_str());
   }
 };
 
@@ skipping 72 matching lines @@
 TEST_PPAPI_OUT_OF_PROCESS(Graphics2D)
 TEST_PPAPI_NACL_VIA_HTTP(Graphics2D)
 
 TEST_PPAPI_IN_PROCESS(ImageData)
 TEST_PPAPI_OUT_OF_PROCESS(ImageData)
 TEST_PPAPI_NACL_VIA_HTTP(ImageData)
 
 TEST_PPAPI_IN_PROCESS(Buffer)
 TEST_PPAPI_OUT_OF_PROCESS(Buffer)
 
+TEST_PPAPI_NACL_VIA_HTTP(TCPSocketPrivateShared)

[polina, 2011/11/29 05:20:47]

A ppapi test should occur as IN, OUT and NACL. This way you can separate trusted
from unstrusted and isolate failure coming from Chrome implementation from the
failures coming from the NaCl implemenataion. The the Chrome IPC proxy does not
even overlap with NaCl test.

[ygorshenin, 2011/11/29 13:25:18]

Added TEST_PPAPI_OUT_OF_PROCESS(...). TEST_PPAPI_IN_PROCESS doesn't work and in
future will be investigated.

[polina, 2011/11/30 01:26:21]

TEST_PPAPI_IN_PROCESS tests your chrome implementation (the other CL) with an
in-process plugin. It is very alarming that the test does not pass.

Please at least add a TODO here with a bug id for this. You might also let the
reviewers of the other CL know about this. Technically this test change belongs
in the other CL.

+TEST_PPAPI_NACL_VIA_HTTP(UDPSocketPrivateShared)
+
 TEST_PPAPI_IN_PROCESS_VIA_HTTP(URLLoader)
 // http://crbug.com/89961
 #if defined(OS_WIN)
 // It often takes too long time (and fails otherwise) on Windows.
 #define MAYBE_URLLoader DISABLED_URLLoader
 #else
 #define MAYBE_URLLoader FAILS_URLLoader
 #endif
 TEST_F(OutOfProcessPPAPITest, MAYBE_URLLoader) {
   RunTestViaHTTP("URLLoader");
@@ skipping 171 matching lines @@
 TEST_PPAPI_OUT_OF_PROCESS(Flash_MessageLoop)
 TEST_PPAPI_OUT_OF_PROCESS(Flash_GetLocalTimeZoneOffset)
 TEST_PPAPI_OUT_OF_PROCESS(Flash_GetCommandLineArgs)
 
 TEST_PPAPI_IN_PROCESS(WebSocket_InvalidConnect)
 TEST_PPAPI_IN_PROCESS(WebSocket_IsWebSocket)
 TEST_PPAPI_IN_PROCESS_WITH_WS(WebSocket_ValidConnect)
 TEST_PPAPI_IN_PROCESS_WITH_WS(WebSocket_TextSendReceive)
 
 #endif // ADDRESS_SANITIZER