Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(781)

Unified Diff: src/mark-compact.cc

Issue 8554009: Set the code age field of SharedFunctionInfo correctly. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/objects-inl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/mark-compact.cc
diff --git a/src/mark-compact.cc b/src/mark-compact.cc
index 09dcc310c2fa7792ed925c0755c011636d762f4e..74c077758b5fc81ae2a5f006966aff61b829dae9 100644
--- a/src/mark-compact.cc
+++ b/src/mark-compact.cc
@@ -1012,7 +1012,9 @@ class StaticMarkingVisitor : public StaticVisitorBase {
MarkBit code_mark =
Marking::MarkBitFrom(function->unchecked_code());
if (code_mark.Get()) {
- shared_info->set_code_age(0);
+ if (!Marking::MarkBitFrom(shared_info).Get()) {
ulan 2011/11/21 17:36:15 Do not reset the code age if the shared info visit
+ shared_info->set_code_age(0);
+ }
return false;
}
@@ -1030,7 +1032,6 @@ class StaticMarkingVisitor : public StaticVisitorBase {
MarkBit code_mark =
Marking::MarkBitFrom(shared_info->unchecked_code());
if (code_mark.Get()) {
- shared_info->set_code_age(0);
ulan 2011/11/21 17:36:15 Do not reset the code age, the JSFunction visitor(
return false;
}
« no previous file with comments | « no previous file | src/objects-inl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698