Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 8554002: Added a switch to enable a unified text checker and asynchronous (Closed)

Created:
9 years, 1 month ago by shinyak (Google)
Modified:
9 years ago
CC:
chromium-reviews, darin-cc_chromium.org, ajwong+watch_chromium.org, creis+watch_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Added a switch to enable a unified text checker and asynchronous text checking. It will enable us to use asynchronous spelling text checking feature which will be implemeneted in WebKit. BUG=106968 TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113792

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M chrome/browser/tab_contents/render_view_host_delegate_helper.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M webkit/glue/webpreferences.h View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/glue/webpreferences.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
shinyak (Google)
Darin, Avi, I think this is a trivial change, so could you see this? Morrita, ...
9 years, 1 month ago (2011-11-21 13:11:46 UTC) #1
darin (slow to review)
http://codereview.chromium.org/8554002/diff/1/chrome/browser/tab_contents/render_view_host_delegate_helper.cc File chrome/browser/tab_contents/render_view_host_delegate_helper.cc (right): http://codereview.chromium.org/8554002/diff/1/chrome/browser/tab_contents/render_view_host_delegate_helper.cc#newcode509 chrome/browser/tab_contents/render_view_host_delegate_helper.cc:509: web_prefs.unified_textchecker_enabled = if both of these fields in WebPreferences ...
9 years, 1 month ago (2011-11-21 19:04:19 UTC) #2
shinyak (Google)
> if both of these fields in WebPreferences are set to the exact same value, ...
9 years, 1 month ago (2011-11-22 02:09:42 UTC) #3
Hajime Morrita
LGTM
9 years ago (2011-11-28 02:14:39 UTC) #4
shinyak (Google)
Darin, Avi, Could you see this?
9 years ago (2011-12-01 02:48:42 UTC) #5
shinyak (Google)
Darin, Avi, ping?
9 years ago (2011-12-05 08:05:08 UTC) #6
Avi (use Gerrit)
lgtm
9 years ago (2011-12-08 14:06:55 UTC) #7
Avi (use Gerrit)
Oh. Fix typos in the change description. Do not put review instructions in the change ...
9 years ago (2011-12-08 15:29:24 UTC) #8
tony
LGTM
9 years ago (2011-12-08 17:53:01 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shinyak@google.com/8554002/4001
9 years ago (2011-12-09 10:34:11 UTC) #10
commit-bot: I haz the power
9 years ago (2011-12-09 11:56:05 UTC) #11
Change committed as 113792

Powered by Google App Engine
This is Rietveld 408576698