chrome/browser/ui/app_modal_dialogs/js_modal_dialog.cc - Issue 8553001: views: Add an Options enum to MessageBoxView control.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/app_modal_dialogs/js_modal_dialog.cc

Issue 8553001: views: Add an Options enum to MessageBoxView control. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: adding an IPC_MESSAGE_EXPORT to line 30 of param_traits_macro.h makes it link in shared build Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/app_modal_dialogs/js_modal_dialog.cc

diff --git a/chrome/browser/ui/app_modal_dialogs/js_modal_dialog.cc b/chrome/browser/ui/app_modal_dialogs/js_modal_dialog.cc

index be579cd1e7f637eefb763bedc5bd8cb1d7ba65ed..d48a722006579039a3c6ee68c1ea072fb0581e1e 100644

--- a/chrome/browser/ui/app_modal_dialogs/js_modal_dialog.cc

+++ b/chrome/browser/ui/app_modal_dialogs/js_modal_dialog.cc

@@ -50,7 +50,7 @@ JavaScriptAppModalDialog::JavaScriptAppModalDialog(

content::JavaScriptDialogDelegate* delegate,

ChromeJavaScriptDialogExtraData* extra_data,

const string16& title,

- int dialog_flags,

+ ui::JavascriptMessageType javascript_message_type,

const string16& message_text,

const string16& default_prompt_text,

bool display_suppress_checkbox,

@@ -58,7 +58,7 @@ JavaScriptAppModalDialog::JavaScriptAppModalDialog(

IPC::Message* reply_msg)

: AppModalDialog(delegate, title),

extra_data_(extra_data),

- dialog_flags_(dialog_flags),

+ javascript_message_type_(javascript_message_type),

display_suppress_checkbox_(display_suppress_checkbox),

is_before_unload_dialog_(is_before_unload_dialog),

reply_msg_(reply_msg),