chrome/browser/tab_contents/web_contents_unittest.cc - Issue 8553001: views: Add an Options enum to MessageBoxView control.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/tab_contents/web_contents_unittest.cc

Issue 8553001: views: Add an Options enum to MessageBoxView control. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: adding an IPC_MESSAGE_EXPORT to line 30 of param_traits_macro.h makes it link in shared build Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/tab_contents/web_contents_unittest.cc

diff --git a/chrome/browser/tab_contents/web_contents_unittest.cc b/chrome/browser/tab_contents/web_contents_unittest.cc

index da5957d18dd8a6d07c9c05a57ca90eaa743e7a65..9a1844b00b52710651da7826f828ba09de17e752 100644

--- a/chrome/browser/tab_contents/web_contents_unittest.cc

+++ b/chrome/browser/tab_contents/web_contents_unittest.cc

@@ -25,7 +25,6 @@

#include "content/public/common/url_constants.h"

#include "content/test/test_browser_thread.h"

#include "testing/gtest/include/gtest/gtest.h"

-#include "ui/base/message_box_flags.h"

#include "webkit/glue/webkit_glue.h"

using content::BrowserThread;

@@ -1677,7 +1676,7 @@ TEST_F(TabContentsTest, NoJSMessageOnInterstitials) {

bool did_suppress_message = false;

contents()->RunJavaScriptMessage(contents()->render_view_host(),

ASCIIToUTF16("This is an informative message"), ASCIIToUTF16("OK"),

- kGURL, ui::MessageBoxFlags::kIsJavascriptAlert, dummy_message,

+ kGURL, ui::JAVASCRIPT_MESSAGE_TYPE_ALERT, dummy_message,

&did_suppress_message);

EXPECT_TRUE(did_suppress_message);

}