Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1006)

Unified Diff: chrome/browser/ui/app_modal_dialogs/message_box_handler.cc

Issue 8553001: views: Add an Options enum to MessageBoxView control. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: more fixes Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/app_modal_dialogs/message_box_handler.cc
diff --git a/chrome/browser/ui/app_modal_dialogs/message_box_handler.cc b/chrome/browser/ui/app_modal_dialogs/message_box_handler.cc
index 9dc374a865920d655aa5a567e003ff8f8b0bba00..ea09244389e2cac139c36dac22a5c910ae9a3525 100644
--- a/chrome/browser/ui/app_modal_dialogs/message_box_handler.cc
+++ b/chrome/browser/ui/app_modal_dialogs/message_box_handler.cc
@@ -16,7 +16,7 @@
#include "content/browser/javascript_dialogs.h"
#include "grit/generated_resources.h"
#include "ui/base/l10n/l10n_util.h"
-#include "ui/base/message_box_flags.h"
+#include "ui/base/message_box_type.h"
class ChromeJavaScriptDialogCreator : public content::JavaScriptDialogCreator {
public:
@@ -25,7 +25,7 @@ class ChromeJavaScriptDialogCreator : public content::JavaScriptDialogCreator {
virtual void RunJavaScriptDialog(content::JavaScriptDialogDelegate* delegate,
TitleType title_type,
const string16& title,
- int dialog_flags,
+ ui::MessageBoxType message_box_type,
const string16& message_text,
const string16& default_prompt_text,
IPC::Message* reply_message,
@@ -75,7 +75,7 @@ void ChromeJavaScriptDialogCreator::RunJavaScriptDialog(
content::JavaScriptDialogDelegate* delegate,
TitleType title_type,
const string16& title,
- int dialog_flags,
+ ui::MessageBoxType message_box_type,
const string16& message_text,
const string16& default_prompt_text,
IPC::Message* reply_message,
@@ -101,14 +101,14 @@ void ChromeJavaScriptDialogCreator::RunJavaScriptDialog(
display_suppress_checkbox = true;
}
- bool is_alert = dialog_flags == ui::MessageBoxFlags::kIsJavascriptAlert;
+ bool is_alert = message_box_type == ui::MESSAGE_BOX_TYPE_JAVASCRIPT_ALERT;
string16 dialog_title = GetTitle(title_type, title, is_alert);
AppModalDialogQueue::GetInstance()->AddDialog(new JavaScriptAppModalDialog(
delegate,
extra_data,
dialog_title,
- dialog_flags,
+ message_box_type,
message_text,
default_prompt_text,
display_suppress_checkbox,
@@ -130,7 +130,7 @@ void ChromeJavaScriptDialogCreator::RunBeforeUnloadDialog(
delegate,
extra_data,
l10n_util::GetStringUTF16(IDS_BEFOREUNLOAD_MESSAGEBOX_TITLE),
- ui::MessageBoxFlags::kIsJavascriptConfirm,
+ ui::MESSAGE_BOX_TYPE_JAVASCRIPT_CONFIRM,
full_message,
string16(), // default_prompt_text
false, // display_suppress_checkbox

Powered by Google App Engine
This is Rietveld 408576698