ui/base/message_box_type.h - Issue 8553001: views: Add an Options enum to MessageBoxView control.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ui/base/message_box_type.h

Issue 8553001: views: Add an Options enum to MessageBoxView control. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: more fixes Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef UI_BASE_MESSAGE_BOX_TYPE_H_

	6 #define UI_BASE_MESSAGE_BOX_TYPE_H_

	7 #pragma once

	8

	9 namespace ui {

	10

	11 enum MessageBoxType {
	sky 2011/11/30 22:43:12 This name sounds overly generic for what this enum This name sounds overly generic for what this enum is now. Maybe JavaScriptMessageType? tfarina 2011/12/01 12:43:26 Done. Show quoted text On 2011/11/30 22:43:12, sky wrote: > This name sounds overly generic for what this enum is now. Maybe > JavaScriptMessageType? Done.
	12 MESSAGE_BOX_TYPE_JAVASCRIPT_ALERT = 0,
	sky 2011/11/30 22:43:12 Why the = here? Doesn't seem like you need explici Why the = here? Doesn't seem like you need explicit values. tfarina 2011/12/01 12:43:26 Done. Show quoted text On 2011/11/30 22:43:12, sky wrote: > Why the = here? Doesn't seem like you need explicit values. Done.
	13 MESSAGE_BOX_TYPE_JAVASCRIPT_CONFIRM = 1,

	14 MESSAGE_BOX_TYPE_JAVASCRIPT_PROMPT = 2

	15 };

	16

	17 } // namespace ui

	18

	19 #endif // UI_BASE_MESSAGE_BOX_TYPE_H_

OLD	NEW