Fix memory leak in xkeyboard.cc.

Fix memory leak in xkeyboard.cc.

BUG=chromium:103433
TEST=ran linux_memory trybot


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109858

[Daniel Kurtz, 2011-11-14 08:44:49]

The actual change LGTM, but maybe there is another bug there to fix?

http://codereview.chromium.org/8552001/diff/2001/chrome/browser/chromeos/inpu...
File chrome/browser/chromeos/input_method/xkeyboard.cc (right):

http://codereview.chromium.org/8552001/diff/2001/chrome/browser/chromeos/inpu...
chrome/browser/chromeos/input_method/xkeyboard.cc:167: if (string_to_find ==
virtual_mod_str) {
Do you want to compare strings, or addresses?
Perhaps this should be:
  string_to_find.compare(virtual_mod_str)?

[Yusuke Sato, 2011-11-14 08:56:44]

http://codereview.chromium.org/8552001/diff/2001/chrome/browser/chromeos/inpu...
File chrome/browser/chromeos/input_method/xkeyboard.cc (right):

http://codereview.chromium.org/8552001/diff/2001/chrome/browser/chromeos/inpu...
chrome/browser/chromeos/input_method/xkeyboard.cc:167: if (string_to_find ==
virtual_mod_str) {
On 2011/11/14 08:44:50, Daniel Kurtz wrote:
> Do you want to compare strings, or addresses?
> Perhaps this should be:
>   string_to_find.compare(virtual_mod_str)?

I believe std::string does not have the problem since it has an implicit
char*-to-std::string constructor.

For example,

  const char x[] = "abc\0abc";
  const char* y = &x[4];
  std::string y_str(&x[4]);
  if (y != x)
    std::printf("addresses don't match\n");
  if (y_str == x)
    std::printf("strings match\n");

prints

  addresses don't match
  strings match

[Daniel Kurtz, 2011-11-14 09:15:40]

LGTM

[Yusuke Sato, 2011-11-14 09:19:35]

On 2011/11/14 09:15:40, Daniel Kurtz wrote:
> LGTM

Thanks, submitting.

[commit-bot: I haz the power, 2011-11-14 09:19:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yusukes@chromium.org/8552001/2001

[commit-bot: I haz the power, 2011-11-14 10:29:00]

Change committed as 109858