Issue 8551009: Add OVERRIDE to chrome/common/ and nacl/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8551009: Add OVERRIDE to chrome/common/ and nacl/. (Closed)

Created:
9 years, 1 month ago by Avi (use Gerrit)

Modified:
9 years, 1 month ago

Reviewers:
Nico

CC:
chromium-reviews, cbentzel+watch_chromium.org, Erik does not do reviews, mihaip+watch_chromium.org, Aaron Boodman, darin-cc_chromium.org, Paweł Hajdan Jr., native-client-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add OVERRIDE to chrome/common/ and nacl/. BUG=104314 TEST=no change Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110941

Patch Set 1 #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+42 lines, -40 lines)			Patch
M	chrome/common/content_settings_pattern.h	View	2 chunks	+10 lines, -9 lines	0 comments	Download
M	chrome/common/extensions/extension_localization_peer.h	View	1 chunk	+6 lines, -6 lines	0 comments	Download
M	chrome/common/json_pref_store.h	View	2 chunks	+17 lines, -16 lines	0 comments	Download
M	chrome/common/metrics_helpers.h	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	chrome/common/net/gaia/gaia_auth_fetcher.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/net/gaia/gaia_auth_fetcher_unittest.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/service_process_util_posix.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/nacl/nacl_listener.h	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages