chrome/browser/external_tab_container_win.cc - Issue 8551002: browser: Add missing OVERRIDE annotation to ExternalTabContainer implementing TabContentsDelegate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/external_tab_container_win.cc

Issue 8551002: browser: Add missing OVERRIDE annotation to ExternalTabContainer implementing TabContentsDelegate. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: ShowPageInfo does not override any base class methods Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/external_tab_container_win.cc

diff --git a/chrome/browser/external_tab_container_win.cc b/chrome/browser/external_tab_container_win.cc

index 2358b014cddd8294de0628924cacc524901fb4b8..78d0a5e8c24d72f6fc98e87644d7b2ae17b9381a 100644

--- a/chrome/browser/external_tab_container_win.cc

+++ b/chrome/browser/external_tab_container_win.cc

@@ -536,7 +536,7 @@ TabContentsWrapper* ExternalTabContainer::GetConstrainingContentsWrapper(

return source;

}

-bool ExternalTabContainer::IsPopup(const TabContents* source) const {

+bool ExternalTabContainer::IsPopupOrPanel(const TabContents* source) const {

return is_popup_window_;

}

« chrome/browser/external_tab_container_win.h ('K') | « chrome/browser/external_tab_container_win.h ('k') | no next file » | no next file with comments »